From 3f6db2ba3d92df56ffbe73c6e2a3f2ff3ccdde58 Mon Sep 17 00:00:00 2001 From: Evoke Zhang Date: Fri, 6 Feb 2026 15:59:52 +0800 Subject: [PATCH] backlight: fix coverity [1/1] PD#SWPL-254104 Problem: need fix coverity Solution: fix coverity for backlight driver Verify: bu301 Change-Id: I8acaca5a10c03bab97be7f3330f7610c0c7ffabb Signed-off-by: Evoke Zhang --- drivers/media/vout/lcd/backlight/bl_ldim/ldim_dev_config.c | 5 ++--- drivers/media/vout/lcd/backlight/lcd_bl_config.c | 5 +++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/vout/lcd/backlight/bl_ldim/ldim_dev_config.c b/drivers/media/vout/lcd/backlight/bl_ldim/ldim_dev_config.c index 1dbe73f28..2242720cf 100644 --- a/drivers/media/vout/lcd/backlight/bl_ldim/ldim_dev_config.c +++ b/drivers/media/vout/lcd/backlight/bl_ldim/ldim_dev_config.c @@ -1146,10 +1146,9 @@ static int ldim_dev_get_config_from_ini(struct ldim_dev_driver_s *dev_drv, phand } if (fw_cus && fw_cus->fw_param) { - tmp_cnt = lcd_ini_get_array(inip, psec, "param_data", - fw_cus->fw_param->param, 32); + tmp_cnt = lcd_ini_get_array(inip, psec, "param_data", fw_cus->fw_param->param, 32); LDIMPR("custom param size = %d\n", tmp_cnt); - if (tmp_cnt) {//!=0 + if (tmp_cnt > 0) { fw_cus->fw_param->param_len = tmp_cnt; fw_cus->fw_param->param = kcalloc(tmp_cnt, sizeof(int), GFP_KERNEL); if (fw_cus->fw_param->param) { diff --git a/drivers/media/vout/lcd/backlight/lcd_bl_config.c b/drivers/media/vout/lcd/backlight/lcd_bl_config.c index 2c2158d0a..639524eed 100644 --- a/drivers/media/vout/lcd/backlight/lcd_bl_config.c +++ b/drivers/media/vout/lcd/backlight/lcd_bl_config.c @@ -1072,6 +1072,11 @@ int bl_config_load(struct aml_bl_drv_s *bdrv, struct platform_device *pdev, int int ret = 0, i; unsigned char file_type = PANEL_FILE_INVALID; + if (!bdrv || !pdev) { + BLERR("config_load: invalid bdrv or pdev\n"); + return -1; + } + if (bdrv->index == 0) sprintf(ukey_name, "backlight"); else