From 04a58919f8bebb9b456747e0482a70927547c60f Mon Sep 17 00:00:00 2001
From: RaviRaaja <mailstoraviraaja@gmail.com>
Date: Tue, 8 Apr 2025 16:00:41 +0530
Subject: [PATCH] Fix: NULL pointer check in ssh_channel_is_closed

The ssh_channel_is_closed function would crash when
accessing channel->session->alive if session is NULL.
This patch adds a null check before accessing the session
pointer.

- build succeeded
- unit test passed
- no new unit test added

https://gitlab.com/libssh/libssh-mirror/-/issues/239

Signed-off-by: Raviraaja Lakshmanan <mailstoraviraaja@gmail.com>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
---
 src/channels.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/channels.c b/src/channels.c
index d58165cd..309a165d 100644
--- a/src/channels.c
+++ b/src/channels.c
@@ -1728,7 +1728,7 @@ int ssh_channel_is_open(ssh_channel channel)
  */
 int ssh_channel_is_closed(ssh_channel channel)
 {
-    if (channel == NULL) {
+    if (channel == NULL || channel->session == NULL) {
         return SSH_ERROR;
     }
     return (channel->state != SSH_CHANNEL_STATE_OPEN || channel->session->alive == 0);