From 105835d542b8b39f3eb718b63f0e2a759e2f977b Mon Sep 17 00:00:00 2001 From: Jon Simons Date: Sun, 6 Nov 2022 11:34:48 -0500 Subject: [PATCH] tests/pkd: free socket wrapper string upon error In e1a8b359c181508d973da681b1c698db7a6dbd20 a missing `free` was added to `pkd_cleanup_socket_wrapper` to free a string allocated for the socket wrapper directory name. Move that `free` such that it also runs in the error-out paths in `pkd_cleanup_socket_wrapper`, to avoid a leak in those cases, too. Signed-off-by: Jon Simons Reviewed-by: Jakub Jelen (cherry picked from commit 9514547c2aaec4290037e7c28a6a16f973d5a274) --- tests/pkd/pkd_hello.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/pkd/pkd_hello.c b/tests/pkd/pkd_hello.c index 01b1b10d..18ac97b4 100644 --- a/tests/pkd/pkd_hello.c +++ b/tests/pkd/pkd_hello.c @@ -1011,12 +1011,12 @@ static int pkd_cleanup_socket_wrapper(void) { goto errrmdir; } - free(pkd_dargs.opts.socket_wrapper.mkdtemp_str); - - goto out; + goto outfree; errrmdir: errrmfiles: rc = -1; +outfree: + free(pkd_dargs.opts.socket_wrapper.mkdtemp_str); out: return rc; }