shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-09 09:54:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fixed possible memory leak in lowercase function.

Browse Source 
If user passed NULL pointer to lowercase() function, duplicated
string "new" wasn't freed before return.

Signed-off-by: Dmitry V. Krivenok <krivenok@orangesystem.ru>
Signed-off-by: Andreas Schneider <mail@cynapses.org>
This commit is contained in:
Dmitry V. Krivenok
2009-09-10 16:08:41 +04:00
committed by Andreas Schneider
parent 2a10019f82
commit 18bce13617
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libssh/keyfiles.c
View File

@@ -1019,11 +1019,12 @@ static int alldigits(const char *s) {
*/ */
static char *lowercase(const char* str) { static char *lowercase(const char* str) {
char *p = 0; char *p = 0;
char *new = strdup(str); char *new = NULL;
if((str == NULL) || (new == NULL)) { if(str == NULL) return NULL;
return NULL;
} new = strdup(str);
if(new == NULL) return NULL;
for (p = new; *p; p++) { for (p = new; *p; p++) {
*p = tolower(*p); *p = tolower(*p);