shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-11 10:40:27 +09:00
Code Issues Packages Projects Releases Wiki Activity

session: Avoid memory leaks

Browse Source 
Thanks coverity

CID 1531417

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Norbert Pocs <norbertpocs0@gmail.com>
This commit is contained in:
Jakub Jelen
2023-12-20 09:43:18 +01:00
parent 71c47b464a
commit 283d75802d
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/session.c
View File

@@ -1026,8 +1026,8 @@ int ssh_get_pubkey_hash(ssh_session session, unsigned char **hash)
{ {
ssh_key pubkey = NULL; ssh_key pubkey = NULL;
ssh_string pubkey_blob = NULL; ssh_string pubkey_blob = NULL;
MD5CTX ctx; MD5CTX ctx = NULL;
unsigned char *h; unsigned char *h = NULL;
int rc; int rc;
if (session == NULL || hash == NULL) { if (session == NULL || hash == NULL) {
@@ -1064,11 +1064,13 @@ int ssh_get_pubkey_hash(ssh_session session, unsigned char **hash)
h = calloc(MD5_DIGEST_LEN, sizeof(unsigned char)); h = calloc(MD5_DIGEST_LEN, sizeof(unsigned char));
if (h == NULL) { if (h == NULL) {
SSH_STRING_FREE(pubkey_blob);
return SSH_ERROR; return SSH_ERROR;
} }
ctx = md5_init(); ctx = md5_init();
if (ctx == NULL) { if (ctx == NULL) {
SSH_STRING_FREE(pubkey_blob);
SAFE_FREE(h); SAFE_FREE(h);
return SSH_ERROR; return SSH_ERROR;
} }
@@ -1077,6 +1079,7 @@ int ssh_get_pubkey_hash(ssh_session session, unsigned char **hash)
ssh_string_data(pubkey_blob), ssh_string_data(pubkey_blob),
ssh_string_len(pubkey_blob)); ssh_string_len(pubkey_blob));
if (rc != SSH_OK) { if (rc != SSH_OK) {
SSH_STRING_FREE(pubkey_blob);
md5_ctx_free(ctx); md5_ctx_free(ctx);
SAFE_FREE(h); SAFE_FREE(h);
return rc; return rc;