shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-06 10:27:22 +09:00
Code Issues Packages Projects Releases Wiki Activity

CVE-2025-4878 Initialize pointers where possible

Browse Source 
This is mostly mechanical change initializing all the pointers I was able to
find with some grep and manual review of sources and examples.

Used the following greps (which yield some false positives though):

    git grep "    \w* *\* *\w*;$"
    git grep " ssh_session \w*;"
    git grep " ssh_channel \w*;"
    git grep " struct ssh_iterator \*\w*;"
    git grep " ssh_bind \w*;"
    git grep " ssh_key \w*;"
    git grep " ssh_string \w*;"
    git grep " ssh_buffer \w*;"
    git grep " HMACCTX \w*;"
    git grep " SHACTX \w*;"
    grep -rinP '^(?!.*=)\s*(?:\w+\s+)*\w+\s*\*\s*\w+\s*;'

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2025-04-23 17:57:11 +02:00
committed by Andreas Schneider
parent 5d27f69494
commit 2eb2af4426
62 changed files with 352 additions and 336 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/session.c
View File

@@ -59,7 +59,7 @@
*/
ssh_session ssh_new(void)
{
ssh_session session;
ssh_session session = NULL;
char *id = NULL;
int rc;
@@ -294,7 +294,7 @@ void ssh_free(ssh_session session)
/* options */
if (session->opts.identity) {
char *id;
char *id = NULL;
for (id = ssh_list_pop_head(char *, session->opts.identity);
id != NULL;
@@ -305,7 +305,7 @@ void ssh_free(ssh_session session)
}
if (session->opts.identity_non_exp) {
char *id;
char *id = NULL;
for (id = ssh_list_pop_head(char *, session->opts.identity_non_exp);
id != NULL;
@@ -1228,7 +1228,7 @@ int ssh_get_publickey_hash(const ssh_key key,
unsigned char **hash,
size_t *hlen)
{
ssh_string blob;
ssh_string blob = NULL;
unsigned char *h = NULL;
int rc;
@@ -1239,7 +1239,7 @@ int ssh_get_publickey_hash(const ssh_key key,
switch (type) {
case SSH_PUBLICKEY_HASH_SHA1: {
SHACTX ctx;
SHACTX ctx = NULL;
h = calloc(1, SHA_DIGEST_LEN);
if (h == NULL) {
@@ -1270,7 +1270,7 @@ int ssh_get_publickey_hash(const ssh_key key,
break;
}
case SSH_PUBLICKEY_HASH_SHA256: {
SHA256CTX ctx;
SHA256CTX ctx = NULL;
h = calloc(1, SHA256_DIGEST_LEN);
if (h == NULL) {
@@ -1301,7 +1301,7 @@ int ssh_get_publickey_hash(const ssh_key key,
break;
}
case SSH_PUBLICKEY_HASH_MD5: {
MD5CTX ctx;
MD5CTX ctx = NULL;
/* In FIPS mode, we cannot use MD5 */
if (ssh_fips_mode()) {