shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-05 04:40:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

CVE-2025-4878 Initialize pointers where possible

Browse Source 
This is mostly mechanical change initializing all the pointers I was able to
find with some grep and manual review of sources and examples.

Used the following greps (which yield some false positives though):

    git grep "    \w* *\* *\w*;$"
    git grep " ssh_session \w*;"
    git grep " ssh_channel \w*;"
    git grep " struct ssh_iterator \*\w*;"
    git grep " ssh_bind \w*;"
    git grep " ssh_key \w*;"
    git grep " ssh_string \w*;"
    git grep " ssh_buffer \w*;"
    git grep " HMACCTX \w*;"
    git grep " SHACTX \w*;"
    grep -rinP '^(?!.*=)\s*(?:\w+\s+)*\w+\s*\*\s*\w+\s*;'

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2025-04-23 17:57:11 +02:00
committed by Andreas Schneider
parent 5d27f69494
commit 2eb2af4426
62 changed files with 352 additions and 336 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/string.c
View File

@@ -108,7 +108,7 @@ int ssh_string_fill(struct ssh_string_struct *s, const void *data, size_t len)
*/
struct ssh_string_struct *ssh_string_from_char(const char *what)
{
struct ssh_string_struct *ptr;
struct ssh_string_struct *ptr = NULL;
size_t len;
if (what == NULL) {
@@ -184,7 +184,7 @@ const char *ssh_string_get_char(struct ssh_string_struct *s)
char *ssh_string_to_char(struct ssh_string_struct *s)
{
size_t len;
char *new;
char *new = NULL;
if (s == NULL) {
return NULL;
@@ -225,7 +225,7 @@ void ssh_string_free_char(char *s)
*/
struct ssh_string_struct *ssh_string_copy(struct ssh_string_struct *s)
{
struct ssh_string_struct *new;
struct ssh_string_struct *new = NULL;
size_t len;
if (s == NULL) {