From 4af4b59e215748b1d6c6ff84f2fa6046df7ed7f3 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 3 Sep 2018 17:57:06 +0200 Subject: [PATCH] channels: Reformat ssh_channel_free() Signed-off-by: Andreas Schneider Reviewed-by: Jakub Jelen --- src/channels.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/src/channels.c b/src/channels.c index 657b68e5..03ef42de 100644 --- a/src/channels.c +++ b/src/channels.c @@ -1007,22 +1007,26 @@ void ssh_channel_free(ssh_channel channel) { * @brief Effectively free a channel, without caring about flags */ -void ssh_channel_do_free(ssh_channel channel){ - struct ssh_iterator *it; - ssh_session session = channel->session; - it = ssh_list_find(session->channels, channel); - if(it != NULL){ - ssh_list_remove(session->channels, it); - } - ssh_buffer_free(channel->stdout_buffer); - ssh_buffer_free(channel->stderr_buffer); - if (channel->callbacks != NULL){ - ssh_list_free(channel->callbacks); - } +void ssh_channel_do_free(ssh_channel channel) +{ + struct ssh_iterator *it = NULL; + ssh_session session = channel->session; - /* debug trick to catch use after frees */ - memset(channel, 'X', sizeof(struct ssh_channel_struct)); - SAFE_FREE(channel); + it = ssh_list_find(session->channels, channel); + if (it != NULL) { + ssh_list_remove(session->channels, it); + } + + ssh_buffer_free(channel->stdout_buffer); + ssh_buffer_free(channel->stderr_buffer); + + if (channel->callbacks != NULL) { + ssh_list_free(channel->callbacks); + } + + /* debug trick to catch use after frees */ + memset(channel, 'X', sizeof(struct ssh_channel_struct)); + SAFE_FREE(channel); } /**