From 5504ff40515439a5fecbb17da7483000c4d12eb7 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 23 Apr 2025 13:42:13 +0200 Subject: [PATCH] CVE-2025-5449 sftpserver: Use constant for return values Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/sftpserver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sftpserver.c b/src/sftpserver.c index 648cab95..9d00efa5 100644 --- a/src/sftpserver.c +++ b/src/sftpserver.c @@ -1829,13 +1829,13 @@ sftp_channel_default_data_callback(UNUSED_PARAM(ssh_session session), if (sftpp == NULL) { SSH_LOG(SSH_LOG_WARNING, "NULL userdata passed to callback"); - return -1; + return SSH_ERROR; } sftp = *sftpp; decode_len = sftp_decode_channel_data_to_packet(sftp, data, len); - if (decode_len == -1) - return -1; + if (decode_len == SSH_ERROR) + return SSH_ERROR; msg = sftp_get_client_message_from_packet(sftp); rc = process_client_message(msg);