shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-10 18:28:10 +09:00
Code Issues Packages Projects Releases Wiki Activity

sftpserver: Use correct type for lseek return value

Browse Source 
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Sahana Prasad <sahana@redhat.com>
Reviewed-by: Eshan Kelkar <eshankelkar@galorithm.com>
This commit is contained in:
Jakub Jelen
2024-07-16 15:20:32 +02:00
committed by Sahana Prasad
parent 7d82bc377f
commit 60ec21a5bf
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sftpserver.c
View File

@@ -946,7 +946,7 @@ process_read(sftp_client_message client_msg)
ssize_t readn = 0; ssize_t readn = 0;
int fd = -1; int fd = -1;
char *buffer = NULL; char *buffer = NULL;
int rv; off_t off;
ssh_log_hexdump("Processing read: handle:", ssh_log_hexdump("Processing read: handle:",
(const unsigned char *)ssh_string_get_char(handle), (const unsigned char *)ssh_string_get_char(handle),
@@ -962,8 +962,8 @@ process_read(sftp_client_message client_msg)
SSH_LOG(SSH_LOG_PROTOCOL, "invalid fd (%d) received from handle", fd); SSH_LOG(SSH_LOG_PROTOCOL, "invalid fd (%d) received from handle", fd);
return SSH_ERROR; return SSH_ERROR;
} }
rv = lseek(fd, client_msg->offset, SEEK_SET); off = lseek(fd, client_msg->offset, SEEK_SET);
if (rv == -1) { if (off == -1) {
sftp_reply_status(client_msg, SSH_FX_FAILURE, NULL); sftp_reply_status(client_msg, SSH_FX_FAILURE, NULL);
SSH_LOG(SSH_LOG_PROTOCOL, SSH_LOG(SSH_LOG_PROTOCOL,
"error seeking file fd: %d at offset: %" PRIu64, "error seeking file fd: %d at offset: %" PRIu64,
@@ -1004,7 +1004,7 @@ process_write(sftp_client_message client_msg)
int fd = -1; int fd = -1;
const char *msg_data = NULL; const char *msg_data = NULL;
uint32_t len; uint32_t len;
int rv; off_t off;
ssh_log_hexdump("Processing write: handle", ssh_log_hexdump("Processing write: handle",
(const unsigned char *)ssh_string_get_char(handle), (const unsigned char *)ssh_string_get_char(handle),
@@ -1023,8 +1023,8 @@ process_write(sftp_client_message client_msg)
msg_data = ssh_string_get_char(client_msg->data); msg_data = ssh_string_get_char(client_msg->data);
len = ssh_string_len(client_msg->data); len = ssh_string_len(client_msg->data);
rv = lseek(fd, client_msg->offset, SEEK_SET); off = lseek(fd, client_msg->offset, SEEK_SET);
if (rv == -1) { if (off == -1) {
sftp_reply_status(client_msg, SSH_FX_FAILURE, NULL); sftp_reply_status(client_msg, SSH_FX_FAILURE, NULL);
SSH_LOG(SSH_LOG_PROTOCOL, SSH_LOG(SSH_LOG_PROTOCOL,
"error seeking file at offset: %" PRIu64, "error seeking file at offset: %" PRIu64,