shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-10 18:28:10 +09:00
Code Issues Packages Projects Releases Wiki Activity

auth: Fix memory leak in ssh_userauth_publickey_auto()

Browse Source 
When a key is rejected, free the allocated memory before returning.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Anderson Toshiyuki Sasaki
2020-03-02 11:36:18 +01:00
committed by Andreas Schneider
parent 46c54e5ddb
commit 6bd2b93f43
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/auth.c
View File

@@ -1132,7 +1132,9 @@ int ssh_userauth_publickey_auto(ssh_session session,
"Public key authentication error for %s", "Public key authentication error for %s",
privkey_file); privkey_file);
ssh_key_free(state->privkey); ssh_key_free(state->privkey);
state->privkey = NULL;
ssh_key_free(state->pubkey); ssh_key_free(state->pubkey);
state->pubkey = NULL;
SAFE_FREE(session->auth.auto_state); SAFE_FREE(session->auth.auto_state);
return rc; return rc;
} else if (rc == SSH_AUTH_AGAIN) { } else if (rc == SSH_AUTH_AGAIN) {
@@ -1198,6 +1200,9 @@ int ssh_userauth_publickey_auto(ssh_session session,
return rc; return rc;
} }
ssh_key_free(state->privkey);
ssh_key_free(state->pubkey);
SSH_LOG(SSH_LOG_WARN, SSH_LOG(SSH_LOG_WARN,
"The server accepted the public key but refused the signature"); "The server accepted the public key but refused the signature");
state->it = state->it->next; state->it = state->it->next;