From 7f442afd5748d9791e9821d571b6a9561ae2c036 Mon Sep 17 00:00:00 2001
From: Wenjie Yang <yangw.ing@foxmail.com>
Date: Wed, 1 May 2024 14:22:12 +0800
Subject: [PATCH] Fix missing memory free functions in pki_key_to_blob().

Signed-off-by: Wenjie Yang <yangw.ing@foxmail.com>
Reviewed-by: Sahana Prasad <sahana@redhat.com>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
---
 src/pki_crypto.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/pki_crypto.c b/src/pki_crypto.c
index f4ce8bdf..77a0695f 100644
--- a/src/pki_crypto.c
+++ b/src/pki_crypto.c
@@ -1509,6 +1509,7 @@ ssh_string pki_key_to_blob(const ssh_key key, enum ssh_key_e type)
                 RSA_get0_factors(key_rsa, &bp, &bq);
                 RSA_get0_crt_params(key_rsa, NULL, NULL, &biqmp);
 #else
+                OSSL_PARAM_free(params);
                 rc = EVP_PKEY_todata(key->key, EVP_PKEY_KEYPAIR, &params);
                 if (rc != 1) {
                     goto fail;
@@ -1755,6 +1756,7 @@ ssh_string pki_key_to_blob(const ssh_key key, enum ssh_key_e type)
                 e = NULL;
                 if (type == SSH_KEY_PRIVATE) {
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
+                    OSSL_PARAM_free(params);
                     rc = EVP_PKEY_todata(key->key, EVP_PKEY_KEYPAIR, &params);
                     if (rc < 0) {
                         goto fail;
@@ -1797,6 +1799,7 @@ ssh_string pki_key_to_blob(const ssh_key key, enum ssh_key_e type)
                     }
                 }
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
+                bignum_safe_free(bd);
                 OSSL_PARAM_free(params);
 #endif /* OPENSSL_VERSION_NUMBER */
                 break;