From 8316bf1177c35453899bdbe8a825a2d9afb2e25d Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 3 Jun 2020 10:05:51 +0200 Subject: [PATCH] sftpserver: Add missing return check for ssh_buffer_add_data() Signed-off-by: Andreas Schneider Reviewed-by: Anderson Toshiyuki Sasaki Reviewed-by: Jakub Jelen (cherry picked from commit 2782cb0495b7450bd8fe43ce4af886b66fea6c40) --- src/sftpserver.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/sftpserver.c b/src/sftpserver.c index b639a2ce..9117f155 100644 --- a/src/sftpserver.c +++ b/src/sftpserver.c @@ -73,9 +73,14 @@ sftp_client_message sftp_get_client_message(sftp_session sftp) { return NULL; } - ssh_buffer_add_data(msg->complete_message, - ssh_buffer_get(payload), - ssh_buffer_get_len(payload)); + rc = ssh_buffer_add_data(msg->complete_message, + ssh_buffer_get(payload), + ssh_buffer_get_len(payload)); + if (rc < 0) { + ssh_set_error_oom(session); + sftp_client_message_free(msg); + return NULL; + } ssh_buffer_get_u32(payload, &msg->id);