mirror of
https://git.libssh.org/projects/libssh.git
synced 2026-02-10 18:28:10 +09:00
dh-gex: fix moduli file stream leak
Ensure to close the moduli file stream in `ssh_retrieve_dhgroup`.
The leak is observable with the pkd tests and valgrind with:
valgrind \
--track-fds=yes \
./pkd_hello -i1 \
-t torture_pkd_openssh_rsa_rsa_diffie_hellman_group_exchange_sha256
Signed-off-by: Jon Simons <jon@jonsimons.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
committed by
Andreas Schneider
parent
04c97c0eaf
commit
886681a421
@@ -481,6 +481,7 @@ static int ssh_retrieve_dhgroup(uint32_t pmin,
|
|||||||
size,
|
size,
|
||||||
&generator,
|
&generator,
|
||||||
&modulus);
|
&modulus);
|
||||||
|
fclose(moduli);
|
||||||
if (rc == SSH_ERROR || *size == 0) {
|
if (rc == SSH_ERROR || *size == 0) {
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user