From 8d7245f54bf9b4d2eadc068de76325a898d2a9bb Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 6 Jan 2011 14:31:54 +0100 Subject: [PATCH] keys: Fixed memory leaks in session signing. Found by cppcheck - http://test.libssh.org/cppcheck-analyzer/ --- libssh/keys.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libssh/keys.c b/libssh/keys.c index 56f80ebf..e2d043e3 100644 --- a/libssh/keys.c +++ b/libssh/keys.c @@ -1308,6 +1308,9 @@ ssh_string ssh_do_sign(ssh_session session, ssh_buffer sigbuf, #endif sign->dsa_sign = NULL; break; + default: + signature_free(sign); + return NULL; } #ifdef HAVE_LIBGCRYPT gcry_sexp_release(gcryhash); @@ -1463,6 +1466,9 @@ ssh_string ssh_sign_session_id(ssh_session session, ssh_private_key privatekey) #endif sign->dsa_sign = NULL; break; + default: + signature_free(sign); + return NULL; } #ifdef HAVE_LIBGCRYPT