From 9003f92e8f3df333a033a345203a9f7a88917bdd Mon Sep 17 00:00:00 2001 From: Jon Simons Date: Sat, 9 Sep 2017 20:12:35 -0700 Subject: [PATCH] pkd_daemon.c: force close pkd_state.server_fd upon stop There's a race window between the accept loop's call to accept(2) and it checking `ctx.keep_going`. Forcefully close the server socket such that any raced `accept` ends up failing. Signed-off-by: Jon Simons Reviewed-by: Andreas Schneider --- tests/pkd/pkd_daemon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/pkd/pkd_daemon.c b/tests/pkd/pkd_daemon.c index 3a530793..9860ca56 100644 --- a/tests/pkd/pkd_daemon.c +++ b/tests/pkd/pkd_daemon.c @@ -498,6 +498,7 @@ void pkd_stop(struct pkd_result *out) { int rc = 0; ctx.keep_going = 0; + close(pkd_state.server_fd); rc = pthread_kill(ctx.tid, SIGUSR1); assert_int_equal(rc, 0);