shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-11 18:50:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

Kex: fix coverity warning + edge case

Browse Source
This commit is contained in:
Aris Adamantiadis
2014-02-02 20:50:36 +01:00
parent 22edaf43ee
commit 99f8b2b803
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/kex.c
View File

@@ -397,14 +397,18 @@ int set_client_kex(ssh_session session){
if (methods & (1 << prefered_hostkeys[i])){ if (methods & (1 << prefered_hostkeys[i])){
if (verify_existing_algo(SSH_HOSTKEYS, ssh_key_type_to_char(prefered_hostkeys[i]))){ if (verify_existing_algo(SSH_HOSTKEYS, ssh_key_type_to_char(prefered_hostkeys[i]))){
if(needcoma) if(needcoma)
strcat(methods_buffer,","); strncat(methods_buffer,",",sizeof(methods_buffer)-strlen(methods_buffer)-1);
strcat(methods_buffer, ssh_key_type_to_char(prefered_hostkeys[i])); strncat(methods_buffer, ssh_key_type_to_char(prefered_hostkeys[i]), sizeof(methods_buffer)-strlen(methods_buffer)-1);
needcoma = 1; needcoma = 1;
} }
} }
} }
if(strlen(methods_buffer) > 0){
SSH_LOG(SSH_LOG_DEBUG, "Changing host key method to \"%s\"", methods_buffer); SSH_LOG(SSH_LOG_DEBUG, "Changing host key method to \"%s\"", methods_buffer);
session->opts.wanted_methods[SSH_HOSTKEYS] = strdup(methods_buffer); session->opts.wanted_methods[SSH_HOSTKEYS] = strdup(methods_buffer);
} else {
SSH_LOG(SSH_LOG_DEBUG, "No supported kex method for existing key in known_hosts file");
}
} }
} }