shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-09 18:04:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

dh-gex: Avoid theoretical integer underflow

Browse Source 
The coverity thinks the best_nlines could be 0 for logging at the end of the
function. It is obvious that the 0 is immediately incremented. Changing the code
to do this in one step to make it easier to understand for static analyzers.

 ** CID 1548873:  Integer handling issues  (INTEGER_OVERFLOW)

Thanks coverity

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Sahana Prasad <sahana@redhat.com>
Reviewed-by: Eshan Kelkar <eshankelkar@galorithm.com>
This commit is contained in:
Jakub Jelen
2024-07-15 12:06:08 +02:00
committed by Sahana Prasad
parent eacab52789
commit a001e19882
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/dh-gex.c
View File

@@ -450,10 +450,9 @@ static int ssh_retrieve_dhgroup_file(FILE *moduli,
proposed_size = size + 1; proposed_size = size + 1;
if (proposed_size != *best_size && if (proposed_size != *best_size &&
dhgroup_better_size(pmin, pn, pmax, *best_size, proposed_size)) { dhgroup_better_size(pmin, pn, pmax, *best_size, proposed_size)) {
best_nlines = 0; best_nlines = 1;
*best_size = proposed_size; *best_size = proposed_size;
} } else if (proposed_size == *best_size) {
if (proposed_size == *best_size) {
best_nlines++; best_nlines++;
} }