From a3b2229a4eeb406d8fc3e98806377fbdb0e995ac Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Fri, 25 Jun 2021 20:06:18 +0200 Subject: [PATCH] More consistent logging Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/bignum.c | 2 +- src/kex.c | 2 +- src/pki_crypto.c | 2 +- src/pki_mbedcrypto.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bignum.c b/src/bignum.c index ef8de31f..e9b95194 100644 --- a/src/bignum.c +++ b/src/bignum.c @@ -86,7 +86,7 @@ void ssh_print_bignum(const char *name, const_bignum num) if (num != NULL) { bignum_bn2hex(num, &hex); } - fprintf(stderr, "%s value: %s\n", name, (hex == NULL) ? "(null)" : (char *) hex); + SSH_LOG(SSH_LOG_DEBUG, "%s value: %s\n", name, (hex == NULL) ? "(null)" : (char *) hex); #ifdef HAVE_LIBGCRYPT SAFE_FREE(hex); #elif defined HAVE_LIBCRYPTO diff --git a/src/kex.c b/src/kex.c index d2ee93ba..78a887dd 100644 --- a/src/kex.c +++ b/src/kex.c @@ -1235,7 +1235,7 @@ int ssh_make_sessionid(ssh_session session) session->next_crypto->digest_len); } #ifdef DEBUG_CRYPTO - printf("Session hash: \n"); + SSH_LOG(SSH_LOG_DEBUG, "Session hash: \n"); ssh_log_hexdump("secret hash", session->next_crypto->secret_hash, session->next_crypto->digest_len); ssh_log_hexdump("session id", session->next_crypto->session_id, session->next_crypto->digest_len); #endif diff --git a/src/pki_crypto.c b/src/pki_crypto.c index 4c95286b..83bf4180 100644 --- a/src/pki_crypto.c +++ b/src/pki_crypto.c @@ -1625,7 +1625,7 @@ static int pki_signature_from_rsa_blob(const ssh_key pubkey, } #ifdef DEBUG_CRYPTO - SSH_LOG(SSH_LOG_WARN, "RSA signature len: %lu", (unsigned long)len); + SSH_LOG(SSH_LOG_DEBUG, "RSA signature len: %lu", (unsigned long)len); ssh_log_hexdump("RSA signature", ssh_string_data(sig_blob), len); #endif diff --git a/src/pki_mbedcrypto.c b/src/pki_mbedcrypto.c index 720fe1de..52b298ee 100644 --- a/src/pki_mbedcrypto.c +++ b/src/pki_mbedcrypto.c @@ -891,7 +891,7 @@ static ssh_signature pki_signature_from_rsa_blob(const ssh_key pubkey, const goto errout; } #ifdef DEBUG_CRYPTO - SSH_LOG(SSH_LOG_WARN, "RSA signature len: %lu", (unsigned long)len); + SSH_LOG(SSH_LOG_DEBUG, "RSA signature len: %lu", (unsigned long)len); ssh_log_hexdump("RSA signature", ssh_string_data(sig_blob), len); #endif