shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-09 09:54:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

misc: fix error-checking in ssh_analyze_banner

Browse Source 
Fix error-checking for `strtoul` in `ssh_analyze_banner`, and
enable some tests which demonstrate the fix before-and-after.

Signed-off-by: Jon Simons <jon@jonsimons.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jon Simons
2017-07-11 19:23:39 -04:00
committed by Andreas Schneider
parent a97db12f4f
commit a89a67e008
2 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unittests/torture_misc.c
View File

@@ -332,12 +332,10 @@ static void torture_ssh_analyze_banner(void **state) {
assert_server_banner_rejected("SSH-2.0-OpenSSH_X.9p1");
/* OpenSSH banners: bogus minor */
#if 0 /* these don't pass */
reset_banner_test();
assert_server_banner_rejected("SSH-2.0-OpenSSH_5.Yp1");
reset_banner_test();
assert_client_banner_rejected("SSH-2.0-OpenSSH_5.Yp1");
#endif /* these don't pass */
/* OpenSSH banners: ssh-keyscan(1) */
#if 0 /* these don't pass */