shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-11 10:40:27 +09:00
Code Issues Packages Projects Releases Wiki Activity

packet_cb: Reformat remaining functions

Browse Source 
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2023-08-02 17:17:07 +02:00
parent c925907917
commit d22194f0b1
1 changed files with 137 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

255
src/packet_cb.c
View File

@@ -45,43 +45,50 @@
* *
* @brief Handle a SSH_DISCONNECT packet. * @brief Handle a SSH_DISCONNECT packet.
*/ */
SSH_PACKET_CALLBACK(ssh_packet_disconnect_callback){ SSH_PACKET_CALLBACK(ssh_packet_disconnect_callback)
int rc; {
uint32_t code = 0; int rc;
char *error = NULL; uint32_t code = 0;
ssh_string error_s; char *error = NULL;
(void)user; ssh_string error_s = NULL;
(void)type;
rc = ssh_buffer_get_u32(packet, &code); (void)user;
if (rc != 0) { (void)type;
code = ntohl(code);
}
error_s = ssh_buffer_get_ssh_string(packet); rc = ssh_buffer_get_u32(packet, &code);
if (error_s != NULL) { if (rc != 0) {
error = ssh_string_to_char(error_s); code = ntohl(code);
SSH_STRING_FREE(error_s); }
}
if (error != NULL) { error_s = ssh_buffer_get_ssh_string(packet);
session->peer_discon_msg = strdup(error); if (error_s != NULL) {
} error = ssh_string_to_char(error_s);
SSH_STRING_FREE(error_s);
}
SSH_LOG(SSH_LOG_PACKET, "Received SSH_MSG_DISCONNECT %" PRIu32 ":%s", if (error != NULL) {
code, error != NULL ? error : "no error"); session->peer_discon_msg = strdup(error);
ssh_set_error(session, SSH_FATAL, }
"Received SSH_MSG_DISCONNECT: %" PRIu32 ":%s",
code, error != NULL ? error : "no error");
SAFE_FREE(error);
ssh_socket_close(session->socket); SSH_LOG(SSH_LOG_PACKET,
session->alive = 0; "Received SSH_MSG_DISCONNECT %" PRIu32 ":%s",
session->session_state = SSH_SESSION_STATE_ERROR; code,
/* correctly handle disconnect during authorization */ error != NULL ? error : "no error");
session->auth.state = SSH_AUTH_STATE_FAILED; ssh_set_error(session,
/* TODO: handle a graceful disconnect */ SSH_FATAL,
return SSH_PACKET_USED; "Received SSH_MSG_DISCONNECT: %" PRIu32 ":%s",
code,
error != NULL ? error : "no error");
SAFE_FREE(error);
ssh_socket_close(session->socket);
session->alive = 0;
session->session_state = SSH_SESSION_STATE_ERROR;
/* correctly handle disconnect during authorization */
session->auth.state = SSH_AUTH_STATE_FAILED;
/* TODO: handle a graceful disconnect */
return SSH_PACKET_USED;
} }
/** /**
@@ -89,102 +96,113 @@ SSH_PACKET_CALLBACK(ssh_packet_disconnect_callback){
* *
* @brief Handle a SSH_IGNORE and SSH_DEBUG packet. * @brief Handle a SSH_IGNORE and SSH_DEBUG packet.
*/ */
SSH_PACKET_CALLBACK(ssh_packet_ignore_callback){ SSH_PACKET_CALLBACK(ssh_packet_ignore_callback)
{
(void)session; /* unused */ (void)session; /* unused */
(void)user; (void)user;
(void)type; (void)type;
(void)packet; (void)packet;
SSH_LOG(SSH_LOG_DEBUG,"Received %s packet",type==SSH2_MSG_IGNORE ? "SSH_MSG_IGNORE" : "SSH_MSG_DEBUG");
/* TODO: handle a graceful disconnect */ SSH_LOG(SSH_LOG_DEBUG,
return SSH_PACKET_USED; "Received %s packet",
type == SSH2_MSG_IGNORE ? "SSH_MSG_IGNORE" : "SSH_MSG_DEBUG");
/* TODO: handle a graceful disconnect */
return SSH_PACKET_USED;
} }
SSH_PACKET_CALLBACK(ssh_packet_newkeys){ SSH_PACKET_CALLBACK(ssh_packet_newkeys)
ssh_string sig_blob = NULL; {
ssh_signature sig = NULL; ssh_string sig_blob = NULL;
int rc; ssh_signature sig = NULL;
(void)packet; int rc;
(void)user;
(void)type;
SSH_LOG(SSH_LOG_DEBUG, "Received SSH_MSG_NEWKEYS");
if (session->session_state != SSH_SESSION_STATE_DH || (void)packet;
session->dh_handshake_state != DH_STATE_NEWKEYS_SENT) { (void)user;
ssh_set_error(session, (void)type;
SSH_FATAL,
"ssh_packet_newkeys called in wrong state : %d:%d",
session->session_state,session->dh_handshake_state);
goto error;
}
if(session->server){ SSH_LOG(SSH_LOG_DEBUG, "Received SSH_MSG_NEWKEYS");
/* server things are done in server.c */
session->dh_handshake_state=DH_STATE_FINISHED;
} else {
ssh_key server_key;
/* client */ if (session->session_state != SSH_SESSION_STATE_DH ||
session->dh_handshake_state != DH_STATE_NEWKEYS_SENT) {
/* Verify the host's signature. FIXME do it sooner */ ssh_set_error(session,
sig_blob = session->next_crypto->dh_server_signature; SSH_FATAL,
session->next_crypto->dh_server_signature = NULL; "ssh_packet_newkeys called in wrong state : %d:%d",
session->session_state,
/* get the server public key */ session->dh_handshake_state);
server_key = ssh_dh_get_next_server_publickey(session);
if (server_key == NULL) {
goto error; goto error;
} }
rc = ssh_pki_import_signature_blob(sig_blob, server_key, &sig); if (session->server) {
ssh_string_burn(sig_blob); /* server things are done in server.c */
SSH_STRING_FREE(sig_blob); session->dh_handshake_state=DH_STATE_FINISHED;
if (rc != SSH_OK) { } else {
goto error; ssh_key server_key = NULL;
}
/* Check if signature from server matches user preferences */ /* client */
if (session->opts.wanted_methods[SSH_HOSTKEYS]) {
if (!ssh_match_group(session->opts.wanted_methods[SSH_HOSTKEYS], /* Verify the host's signature. FIXME do it sooner */
sig->type_c)) { sig_blob = session->next_crypto->dh_server_signature;
session->next_crypto->dh_server_signature = NULL;
/* get the server public key */
server_key = ssh_dh_get_next_server_publickey(session);
if (server_key == NULL) {
goto error;
}
rc = ssh_pki_import_signature_blob(sig_blob, server_key, &sig);
ssh_string_burn(sig_blob);
SSH_STRING_FREE(sig_blob);
if (rc != SSH_OK) {
goto error;
}
/* Check if signature from server matches user preferences */
if (session->opts.wanted_methods[SSH_HOSTKEYS]) {
rc = ssh_match_group(session->opts.wanted_methods[SSH_HOSTKEYS],
sig->type_c);
if (rc == 0) {
ssh_set_error(session,
SSH_FATAL,
"Public key from server (%s) doesn't match user "
"preference (%s)",
sig->type_c,
session->opts.wanted_methods[SSH_HOSTKEYS]);
goto error;
}
}
rc = ssh_pki_signature_verify(session,
sig,
server_key,
session->next_crypto->secret_hash,
session->next_crypto->digest_len);
SSH_SIGNATURE_FREE(sig);
if (rc == SSH_ERROR) {
ssh_set_error(session, ssh_set_error(session,
SSH_FATAL, SSH_FATAL,
"Public key from server (%s) doesn't match user " "Failed to verify server hostkey signature");
"preference (%s)", goto error;
sig->type_c, }
session->opts.wanted_methods[SSH_HOSTKEYS]); SSH_LOG(SSH_LOG_DEBUG, "Signature verified and valid");
/* When receiving this packet, we switch on the incoming crypto. */
rc = ssh_packet_set_newkeys(session, SSH_DIRECTION_IN);
if (rc != SSH_OK) {
goto error; goto error;
} }
} }
session->dh_handshake_state = DH_STATE_FINISHED;
session->ssh_connection_callback(session);
return SSH_PACKET_USED;
rc = ssh_pki_signature_verify(session,
sig,
server_key,
session->next_crypto->secret_hash,
session->next_crypto->digest_len);
SSH_SIGNATURE_FREE(sig);
if (rc == SSH_ERROR) {
ssh_set_error(session,
SSH_FATAL,
"Failed to verify server hostkey signature");
goto error;
}
SSH_LOG(SSH_LOG_DEBUG,"Signature verified and valid");
/* When receiving this packet, we switch on the incoming crypto. */
rc = ssh_packet_set_newkeys(session, SSH_DIRECTION_IN);
if (rc != SSH_OK) {
goto error;
}
}
session->dh_handshake_state = DH_STATE_FINISHED;
session->ssh_connection_callback(session);
return SSH_PACKET_USED;
error: error:
SSH_SIGNATURE_FREE(sig); SSH_SIGNATURE_FREE(sig);
ssh_string_burn(sig_blob); ssh_string_burn(sig_blob);
SSH_STRING_FREE(sig_blob); SSH_STRING_FREE(sig_blob);
session->session_state = SSH_SESSION_STATE_ERROR; session->session_state = SSH_SESSION_STATE_ERROR;
return SSH_PACKET_USED; return SSH_PACKET_USED;
} }
/** /**
@@ -192,16 +210,16 @@ error:
* @brief handles a SSH_SERVICE_ACCEPT packet * @brief handles a SSH_SERVICE_ACCEPT packet
* *
*/ */
SSH_PACKET_CALLBACK(ssh_packet_service_accept){ SSH_PACKET_CALLBACK(ssh_packet_service_accept)
(void)packet; {
(void)type; (void)packet;
(void)user; (void)type;
(void)user;
session->auth.service_state = SSH_AUTH_SERVICE_ACCEPTED; session->auth.service_state = SSH_AUTH_SERVICE_ACCEPTED;
SSH_LOG(SSH_LOG_PACKET, SSH_LOG(SSH_LOG_PACKET, "Received SSH_MSG_SERVICE_ACCEPT");
"Received SSH_MSG_SERVICE_ACCEPT");
return SSH_PACKET_USED; return SSH_PACKET_USED;
} }
/** /**
@@ -214,6 +232,7 @@ SSH_PACKET_CALLBACK(ssh_packet_ext_info)
int rc; int rc;
uint32_t nr_extensions = 0; uint32_t nr_extensions = 0;
uint32_t i; uint32_t i;
(void)type; (void)type;
(void)user; (void)user;