From ec67ad47ebe200ad8a6b508e8ca061a073a3fde1 Mon Sep 17 00:00:00 2001 From: Anderson Toshiyuki Sasaki Date: Tue, 5 Nov 2019 14:17:47 +0100 Subject: [PATCH] session: Initialize states explicitly In ssh_session_new(), initialize the state machines states explicitly for better readability. Fixes T194 Signed-off-by: Anderson Toshiyuki Sasaki Reviewed-by: Andreas Schneider --- src/session.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/session.c b/src/session.c index ae291b6d..126562e2 100644 --- a/src/session.c +++ b/src/session.c @@ -162,6 +162,16 @@ ssh_session ssh_new(void) } #endif + /* Explicitly initialize states */ + session->session_state = SSH_SESSION_STATE_NONE; + session->pending_call_state = SSH_PENDING_CALL_NONE; + session->packet_state = PACKET_STATE_INIT; + session->dh_handshake_state = DH_STATE_INIT; + session->global_req_state = SSH_CHANNEL_REQ_STATE_NONE; + + session->auth.state = SSH_AUTH_STATE_NONE; + session->auth.service_state = SSH_AUTH_SERVICE_NONE; + return session; err: