shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-09 09:54:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

dh: fix libcrypto dh_ctx leak in ssh_dh_cleanup

Browse Source 
Ensure to free the `dh_ctx` member in `ssh_dh_cleanup` to match
the allocation in `ssh_dh_init_common`.

The before-and-after of this change can be observed with the pkd
tests and valgrind:

    valgrind --leak-check=full \
      ./pkd_hello -i1 -t torture_pkd_openssh_dsa_rsa_diffie_hellman_group16_sha512

Signed-off-by: Jon Simons <jon@jonsimons.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jon Simons
2019-04-30 11:54:33 -07:00
committed by Andreas Schneider
parent ee82bab801
commit ee42e3badb
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/dh_crypto.c
View File

@@ -180,6 +180,7 @@ void ssh_dh_cleanup(struct ssh_crypto_struct *crypto)
if (crypto->dh_ctx != NULL) { if (crypto->dh_ctx != NULL) {
DH_free(crypto->dh_ctx->keypair[0]); DH_free(crypto->dh_ctx->keypair[0]);
DH_free(crypto->dh_ctx->keypair[1]); DH_free(crypto->dh_ctx->keypair[1]);
free(crypto->dh_ctx);
crypto->dh_ctx = NULL; crypto->dh_ctx = NULL;
} }
} }