From f5eb3e532bf23f42f65d3ab6f19316946fc21180 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 7 Jan 2026 13:18:23 +0100 Subject: [PATCH] gssapi: Check return value from ssh_gssapi_init() Checking the session->gssapi is resulting in the very same results, but this approach is more direct and makes static analysis tools more happy. Thanks coverity! CID 1644000 Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/gssapi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gssapi.c b/src/gssapi.c index 7c5914d6..c5e907d4 100644 --- a/src/gssapi.c +++ b/src/gssapi.c @@ -616,12 +616,14 @@ ssh_gssapi_creds ssh_gssapi_get_creds(ssh_session session) */ void ssh_gssapi_set_creds(ssh_session session, const ssh_gssapi_creds creds) { + int rc; + if (session == NULL) { return; } if (session->gssapi == NULL) { - ssh_gssapi_init(session); - if (session->gssapi == NULL) { + rc = ssh_gssapi_init(session); + if (rc == SSH_ERROR) { return; } }