Commit Graph

163 Commits

Author SHA1 Message Date
Andreas Schneider
68d04c8e47 CVE-2012-4559: Ensure that we don't free req twice. 2012-11-14 17:36:24 +01:00
Xi Wang
d404ad7152 channels: Fix integer overflow in generate_cookie().
Since the type of rnd[i] is signed char, (rnd[i] >> 4), which is
considered as arithmetic shift by gcc, could be negative, leading
to out-of-bounds read.
2012-10-22 21:00:08 +02:00
Andreas Schneider
dde3deb9ea channels: Don't leak memory in channel_rcv_request callback.
Found by Coverity.
2012-10-12 08:07:02 +02:00
Andreas Schneider
bb2848de5a channels: Check return values of buffer functions.
Found by Coverity.
2012-10-09 11:09:34 +02:00
Andreas Schneider
ceb8072b34 channel: Fix a possible null pointer dereference. 2012-10-05 11:17:06 +02:00
Andreas Schneider
656fd60110 channels: Fix a possible null pointer dereference. 2012-10-05 11:16:03 +02:00
Andreas Schneider
332f1a2a51 channels: Fix a memory leak in ssh_channel_select(). 2012-10-05 11:12:13 +02:00
Andreas Schneider
3739bd99c5 channels: Fix return value of ssh_channel_request_pty_size with SSHv1.
Thanks to Dmitriy Kuznetsov <dk@yandex.ru>.
2012-09-07 12:21:28 +02:00
Andreas Schneider
782b2e37c6 build: Fix missing struct in_addr warning. 2012-07-17 18:16:07 +02:00
Aris Adamantiadis
046aa02f39 Fix bugs found by clang 2011-09-23 22:27:46 +02:00
Aris Adamantiadis
dad35304b6 channels: fix embarrasing channel_read_nonblocking bug 2011-09-22 13:48:21 +03:00
Andreas Schneider
c19c638d74 error: Use macros for error functions. 2011-09-17 10:38:08 +02:00
Aris Adamantiadis
36ec488663 channels: don't send SSH2 packets on SSH1 ! 2011-09-14 22:35:12 +02:00
Aris Adamantiadis
7e5f1edcb4 auth: fix things broken during merge 2011-09-02 14:09:12 +03:00
Aris Adamantiadis
20f8e73e3e Update libssh to ssh_handle_packets_termination
cherry-picked from 0cb5248

Should resolve all timeout problems

Conflicts:

	src/auth.c
	src/channels.c
2011-09-02 13:58:37 +03:00
Aris Adamantiadis
ef5701a535 Channels: fix the "server specified invalid channel" bug
Resolved by introducing a flag entry in channel structure.
2011-09-02 13:50:06 +03:00
Aris Adamantiadis
7d347aa6f4 channel: ssh_channel_read is nonblocking, + docfixes
cherry-picked from 6091147
Conflicts:

	src/channels.c
2011-09-02 13:49:05 +03:00
Aris Adamantiadis
6d8bb956c5 channels: replaced bugged lists with ssh_list
cherry-picked from 0aef5f
Conflicts:

	src/session.c
2011-09-02 13:46:10 +03:00
Aris Adamantiadis
3eece8ac0b SSH1: fix build 2011-09-02 11:43:12 +03:00
Aris Adamantiadis
92c8a71abb ssh_select converted to ssh_event, and bugfix to ssh_channel_select 2011-09-02 11:43:12 +03:00
Aris Adamantiadis
d1ebc4697a channels: ssh_channel_select implemented with ssh_poll
Should fix #56
2011-09-02 11:43:11 +03:00
Aris Adamantiadis
cb2a111fa1 channel: implement ssh_channel_poll_timeout
Resolves bug #57
2011-09-02 11:43:11 +03:00
Aris Adamantiadis
17ae216340 Channels: increase window size x10
Provides me a 3x performance boost for async sftp, 5x for sync sftp
(on localhost)
2011-09-02 11:43:07 +03:00
Aris Adamantiadis
a2c94abb92 channels: made the remaining calls nonblocking + fix #52 2011-09-02 11:42:59 +03:00
Aris Adamantiadis
510c741229 channels: use hard random for the X11 cookie
We are in a security library or we are not.
2011-09-02 11:42:59 +03:00
Aris Adamantiadis
f9dad9ad68 channels: made all channel requests nonblocking 2011-09-02 11:42:59 +03:00
rofl0r
66188f1af8 channels: Fix possible infinite loop in channel_read(). 2011-08-29 21:47:01 +02:00
Andreas Schneider
13227714f2 channels: Fix incorrect return values in ssh_channel_write(). 2011-08-10 16:58:10 +02:00
Andreas Schneider
2f87873642 channels: Handle SSH_AGAIN in channel_open(). 2011-08-09 22:59:17 +02:00
rofl0r
7ccd9c31b3 channels: Fix an endless loop in case of a channel_open error. 2011-08-06 11:12:02 +02:00
rofl0r
af85337f5f session: Fix timeout handling.
-2 now means to use the timeout specified in options. It wasn't used
earlier and poll only knows -1 and 0 anyway for special meanings.
2011-08-06 11:12:02 +02:00
rofl0r
563fbe4de8 channels: Fix checking for fatal errors.
We need this that we don't end up in and infinite poll loop.
2011-08-06 11:11:12 +02:00
rofl0r
39f962c91e channels: Fix ssh_channel_from_local()
It only worked if the first channel in the list was equivalent to we
were looking for.
2011-08-06 11:08:55 +02:00
Andreas Schneider
790b62bca5 channels: Set the max packet size to 32768. 2011-08-03 20:49:57 +02:00
Aris Adamantiadis
ac167c9077 Forgot a cast to remove warnings 2011-05-27 13:36:55 +02:00
Aris Adamantiadis
17454caf64 Fix bug #5, channel_read_nonblocking that blocks 2011-05-27 13:13:02 +02:00
Aris Adamantiadis
a053d819a3 Fixed warnings on MacosX with Xcode4 2011-05-20 14:31:13 +02:00
Oliver Stöneberg
4e153aed8a channel: Fixed potential use-after-free in ssh_channel_get_exit_status().
If ssh_channel_get_exit_status() is called more than once and the
connection closed.
2011-05-17 14:20:56 +02:00
Andreas Schneider
32cd45612b channel: Improve the request signal documentation. 2011-05-15 13:42:38 +02:00
milo
7ba0938846 [channels] Added ssh_channel_window_size() and avoided reentrancy in channel_write_common()
(cherry picked from commit 27313334578f4acb7ccf0687bba7f76b2febd569)
2011-05-02 16:58:27 +02:00
Andreas Schneider
ef658b4bef Fix assertion with Visual Studio because of %zu. 2011-04-15 19:02:21 +02:00
milo
7cc4471168 Implemented X11 server side 2011-04-14 14:05:44 +02:00
milo
8ee8d4f913 Check for NULL channel pointers 2011-02-22 14:11:19 +01:00
Andreas Schneider
5cc2e69d0d channel: Fixed a possible NULL pointe dereference. 2011-02-18 18:03:37 +01:00
Bernhard R. Link
23b3c46fd6 channel: Improve ssh_channel_open_reverse_forward documentation. 2011-02-18 17:50:50 +01:00
Bernhard R. Link
8a83990c16 channels: set error for new NULL pointer checks
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
2011-02-18 17:45:28 +01:00
Bernhard R. Link
7ae59c571a channels: Set errors on return.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
2011-02-14 22:48:53 +01:00
milo
11e54e8221 Check for NULL pointers in channels.c 2011-02-14 20:02:02 +01:00
milo
867944b939 Respect RFC when sending stderr data
http://tools.ietf.org/html/rfc4254#section-5.2

      byte      SSH_MSG_CHANNEL_EXTENDED_DATA
      uint32    recipient channel
     *uint32    data_type_code*
      string    data
2011-02-04 12:46:51 +01:00
Andreas Schneider
38b87aab08 channels: Fixed a build warning. 2010-12-23 10:18:09 +01:00