Andreas Schneider
419731a189
auth: Use calloc in ssh_userauth_agent_pubkey()
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
(cherry picked from commit 79437fa0c9 )
2017-04-21 11:14:39 +02:00
Stef Walter
faca78f547
auth: Cleanup memory leak when using SSH agent
...
In Cockpit we've seen this memory leak:
at 0x4C2A9C7: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5B76B03: ssh_userauth_agent (auth.c:778)
by 0x40DD5A: cockpit_ssh_authenticate (cockpitsshtransport.c:327)
BUG: https://red.libssh.org/issues/208
Signed-off-by: Stef Walter <stefw@redhat.com >
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
(cherry picked from commit ffe8b98cc2 )
2016-05-02 15:29:01 +02:00
Peter Volpe
83387f957f
auth: Fix return status for ssh_userauth_agent()
...
BUG: https://red.libssh.org/issues/201
Return SSH_AUTH_DENIED instead of SSH_AUTH_ERROR when the provided agent
offers no public keys.
Signed-off-by: Peter Volpe <pvolpe@redhat.com >
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
(cherry picked from commit dc9c4d22ab )
2015-07-30 10:52:11 +02:00
Tilo Eckert
63a8f333b8
SSH_AUTH_PARTIAL is now correctly passed to the caller of ssh_userauth_publickey_auto().
...
Implicitly fixed unsafe return code handling that could result in use-after-free.
Signed-off-by: Tilo Eckert <tilo.eckert@flam.de >
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
(cherry picked from commit 0423057424 )
2015-06-29 11:11:26 +02:00
Tilo Eckert
57fd8e3187
available auth_methods must be reset on partial authentication
...
Signed-off-by: Tilo Eckert <tilo.eckert@flam.de >
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
(cherry picked from commit cc25d747d4 )
2015-06-29 11:11:25 +02:00
Andreas Schneider
a3357b8920
include: We should use __func__ which is C99
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2015-04-02 10:58:36 +02:00
Andreas Schneider
5fa4721c6e
auth: Fix a memory leak in agent publickey auth.
...
CID: 1230358
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Aris Adamantiadis <aris@0xbadc0de.be >
2014-08-15 12:29:26 +02:00
Aris Adamantiadis
1f2c61d6ad
buffer: adapt auth.c to ssh_buffer_(un)pack()
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
2014-08-06 09:20:49 +02:00
Andreas Schneider
9c4144689d
src: Rename buffer_init to ssh_buffer_init().
2014-01-19 20:43:29 +01:00
Andreas Schneider
2fe59071b2
src: Do not use deprecated functions.
2014-01-16 15:27:46 +01:00
Aris Adamantiadis
aecd952d18
update copyright information
2014-01-07 15:18:15 +01:00
Colin Walters
f02bc4768e
auth: docs: Fix typo optoins -> options
...
I'm just getting my feet wet with this codebase.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
2013-10-23 09:55:09 +02:00
Andreas Schneider
dbf3cdecda
auth: Fix build warning if we don't build with gssapi.
2013-07-22 13:01:36 +02:00
Andreas Schneider
da1eaea51a
gassapi: Fix check if it is enabled.
2013-07-22 10:42:30 +02:00
Andreas Schneider
c64ec43eef
src: Remove enter_function() and leave_function().
2013-07-14 13:31:24 +02:00
Andreas Schneider
2c91efcc68
log: Implment new logging functions.
2013-07-14 12:36:59 +02:00
Aris Adamantiadis
365a3bba6e
auth: fix warnings with missing switch() params
2013-07-14 09:35:30 +02:00
Andreas Schneider
1663917f71
cmake: Make GSSAPI optional.
2013-07-13 15:48:49 +02:00
Andreas Schneider
9bbbccc0e7
auth: Remove unused code.
2013-07-13 15:29:53 +02:00
Aris Adamantiadis
7cb6b15aaa
auth: implement client-side gssapi
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org >
2013-07-13 14:41:20 +02:00
Andreas Schneider
5d05aec2ef
auth: Cleanup the agent return code.
2013-06-18 16:42:33 +02:00
Nicolas Viennot
6306bee86c
auth: If the agent fails, fall back to regular path
...
It's causing issues on MacOSX when ssh_agent_get_ident_count()
reports "Agent count: 0".
2013-06-18 16:39:31 +02:00
Aris Adamantiadis
63c3f0e736
Implement key re-exchange
2012-12-23 23:09:50 +01:00
Andreas Schneider
66045054f4
auth: Don't leak memory on error in info request callback.
...
Found by Coverity.
2012-10-12 08:07:01 +02:00
Andreas Schneider
131a0de32e
auth: Make error handling code reachable again.
...
Found by Coverity.
2012-10-09 11:09:34 +02:00
Andreas Schneider
782b2e37c6
build: Fix missing struct in_addr warning.
2012-07-17 18:16:07 +02:00
Andreas Schneider
8ef45e00c7
auth: Improve ssh_userauth_kbdint_setanswer() documentation.
...
Thanks to Arto Karppinen.
2012-07-17 18:04:55 +02:00
Andreas Schneider
e8cebc2a37
auth: Fix ssh_userauth_kbdint*() documentation.
...
Thanks to Arto Karppinen.
2012-07-17 18:04:55 +02:00
Andreas Schneider
8624651de3
auth: Fix ssh_userauth_password() documentation.
2012-07-17 18:04:55 +02:00
Andreas Schneider
62657d5f87
auth: Fix build warning.
2012-02-20 09:44:36 +01:00
Andreas Schneider
72001ff8cc
auth: Improve doc of ssh_userauth_kbdint_getprompt().
2012-02-19 13:25:22 +01:00
Andreas Schneider
ee774479de
session: Use a struct for all options.
2012-02-05 11:50:49 +01:00
Andreas Schneider
74f5f43409
auth: Fix public key authentication so we can continue.
2012-01-01 23:53:21 +01:00
Andreas Schneider
0b7b699ced
auth: Fix a possible double free.
2012-01-01 23:53:14 +01:00
Aris Adamantiadis
046aa02f39
Fix bugs found by clang
2011-09-23 22:27:46 +02:00
Andreas Schneider
acfc8ea83f
priv: Remove crypto.h and add correct includes to src files.
2011-09-18 21:37:17 +02:00
Andreas Schneider
c2883c1f37
auth: Use the new SSH_LOG function.
2011-09-17 10:38:08 +02:00
Andreas Schneider
c19c638d74
error: Use macros for error functions.
2011-09-17 10:38:08 +02:00
Aris Adamantiadis
ebfb2a5cdb
auth: fix spelling in error message
2011-09-14 20:37:30 +02:00
Aris Adamantiadis
33cf16488b
Revert "auth: Check if we have any prompts."
...
This reverts commit 3b5bdc5db4 .
It's perfectly legit to have only zero prompts.
2011-09-14 20:36:23 +02:00
Aris Adamantiadis
0fa88fdcfe
Auth: fix possible off-by-one
...
No security impact, only triggable by specific API call
2011-09-14 17:28:41 +03:00
Aris Adamantiadis
1f31415760
auth: made keyboard-interactive nonblocking
2011-09-11 17:39:20 +02:00
Aris Adamantiadis
ff5bf51af1
Auth: nonblocking ssh_userauth_pubkey_auto
2011-09-11 17:22:27 +02:00
Aris Adamantiadis
33bd3d6cd9
auth: Implement nonblocking ssh_auth_agent
2011-09-11 17:22:26 +02:00
Aris Adamantiadis
28bfc7645c
auth: different code for auth_agent
2011-09-11 17:22:26 +02:00
Aris Adamantiadis
ae89dfd6f2
Auth: made ssh_userauth_get_response respect timeout
2011-09-11 17:22:26 +02:00
Andreas Schneider
3b5bdc5db4
auth: Check if we have any prompts.
2011-09-11 15:29:27 +02:00
Aris Adamantiadis
7e5f1edcb4
auth: fix things broken during merge
2011-09-02 14:09:12 +03:00
Aris Adamantiadis
20f8e73e3e
Update libssh to ssh_handle_packets_termination
...
cherry-picked from 0cb5248
Should resolve all timeout problems
Conflicts:
src/auth.c
src/channels.c
2011-09-02 13:58:37 +03:00
Andreas Schneider
822c68eb8e
pki: Use consistent API for ssh_pki_export_privkey_to_pubkey().
2011-08-30 10:28:57 +02:00