Dirkjan Bussink 04824e2f5e Add safety checks for all ssh_string_fill calls ...

These calls can fail and the return code should always be checked. These
issues were identified when code review called it out on new code. The
updates here are to existing code with no behavior changes to make
review simpler.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
(cherry picked from commit daeee74edd)

2021-08-17 15:46:53 +02:00

..

ABI

Bump version to 0.9.5

2020-09-10 14:44:47 +02:00

external

external: Do not confuse new gcc

2020-05-05 14:33:30 +02:00

threads

libcrypto: Fix access violation in ssh_init()

2018-11-30 18:26:55 +01:00

agent.c

agent: Use SSH_BUFFER_FREE()

2019-12-09 16:38:36 +01:00

auth.c

auth: Fix memory leak in ssh_userauth_publickey_auto()

2020-03-29 09:59:52 +02:00

base64.c

base64: Use SSH_BUFFER_FREE()

2019-12-09 16:38:37 +01:00

bignum.c

bignum: Print ssh_make_string_bn() using SSH_LOG()

2019-12-09 16:38:36 +01:00

bind_config.c

bind_config: Fail if a known option couldn't be set

2019-06-12 10:17:54 +02:00

bind.c

Use only one variable denoting the size of methods arrays

2019-12-09 16:38:36 +01:00

buffer.c

buffer: Add NULL check for 'buffer' argument

2020-06-08 09:15:26 +02:00

callbacks.c

callbacks: Implement list of callbacks for channels

2016-05-02 16:56:54 +02:00

chachapoly.c

Replace ssh_print_hexa() with ssh_log_hexdump()

2019-08-08 09:44:18 +02:00

channels.c

channel: Do not return error if the server closed the channel

2020-06-23 19:58:07 +02:00

client.c

client: Reset pending_call_state on disconnect

2021-08-17 15:46:53 +02:00

CMakeLists.txt

cmake: Use OPENSSL_CRYPTO_LIBRARIES CMake variable when linking against OpenSSL

2021-08-17 15:46:53 +02:00

config_parser.c

config: Move common parser functions to config_parser.c

2019-04-01 08:25:22 +02:00

config.c

config: Ignore empty lines to avoid OOB array access

2019-12-09 16:39:24 +01:00

connect.c

channels: Fix integer and bool argument of channel_default_bufferize()

2019-12-09 16:38:36 +01:00

connector.c

connector: Stop socket-to-channel EOF flooding

2019-04-29 13:16:54 +02:00

curve25519.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

dh_crypto.c

kex: Add support for diffie-hellman-group14-sha256

2020-04-06 11:36:35 +02:00

dh_key.c

kex: Add support for diffie-hellman-group14-sha256

2020-04-06 11:36:35 +02:00

dh-gex.c

dh-gex: Check return value of ssh_get_random()

2020-04-06 11:36:33 +02:00

dh.c

kex: Add support for diffie-hellman-group14-sha256

2020-04-06 11:36:35 +02:00

ecdh_crypto.c

ecdh_crypto: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

ecdh_gcrypt.c

ecdh_gcrypt: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

ecdh_mbedcrypto.c

ecdh_mbedcrypto: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

ecdh.c

ecdh: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

error.c

error: Add ssh_reset_error() function

2018-08-27 11:29:18 +02:00

gcrypt_missing.c

dh: Do some basic refactoring

2019-01-24 11:56:23 +01:00

getpass.c

getpass: Use explicit_bzero()

2018-09-04 19:57:31 +02:00

gssapi.c

gssapi: Use SSH_BUFFER_FREE()

2019-12-09 16:38:36 +01:00

gzip.c

gzip: Use SSH_BUFFER_FREE()

2019-12-09 16:38:37 +01:00

init.c

init: Introduce internal is_ssh_initialized()

2020-05-05 14:31:53 +02:00

kdf.c

Use a common KDF function

2019-03-07 12:03:32 +01:00

kex.c

Fix handshake bug with AEAD ciphers and no HMAC overlap

2021-08-17 15:46:53 +02:00

known_hosts.c

known_hosts: Avoid using deprecated functions (even from deprecated functions)

2019-09-30 15:42:26 +02:00

knownhosts.c

knownhosts: Use SSH_BUFFER_FREE()

2019-12-09 16:38:37 +01:00

legacy.c

legacy,keys: Fix the macro conditions

2020-01-23 09:49:26 +01:00

libcrypto-compat.c

libcrypto-compat: Fix indentation and return value

2020-05-05 14:32:27 +02:00

libcrypto-compat.h

libcrypto-compat: add extra functions

2020-05-05 14:32:15 +02:00

libcrypto.c

libcrypto: remove deprecated API usage

2020-05-05 14:32:23 +02:00

libgcrypt.c

libgcrypt: Do not leak memory with invalid key lengths

2020-01-23 09:49:35 +01:00

libmbedcrypto.c

wrapper: Make sha{1, 256, 384, 512}() input const

2019-05-13 16:37:51 +02:00

libssh.map

Bump SO version to 4.8.1

2019-06-14 15:22:56 +02:00

log.c

log: Make sure the buffer for date is big enough

2018-08-20 18:42:03 +02:00

match.c

match: Limit possible recursion when parsing wildcards to a sensible number

2019-12-09 16:38:37 +01:00

mbedcrypto_missing.c

mbedcrypto_missing: Always check return values

2020-01-23 09:49:22 +01:00

messages.c

messages: Add missing NULL check

2020-01-23 09:50:35 +01:00

misc.c

misc: Add a function to encode newlines

2019-12-09 16:38:37 +01:00

options.c

options: Avoid needless assignment as reported by csbuild

2020-01-23 09:49:07 +01:00

packet_cb.c

packet_cb: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

packet_crypt.c

packet_crypt: Check return values from AEAD deciphering

2020-01-23 10:31:44 +01:00

packet.c

Ignore request success and failure message if they are not expected

2021-08-17 15:46:53 +02:00

pcap.c

pcap: Use SSH_BUFFER_FREE()

2019-12-09 16:38:37 +01:00

pki_container_openssh.c

pki: Fix possible information leak via uninitialized stack buffer

2019-12-09 16:38:37 +01:00

pki_crypto.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

pki_ed25519_common.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

pki_ed25519.c

pki: Move common Ed25519 functions to pki_ed25519_common.c

2019-09-30 16:57:16 +02:00

pki_gcrypt.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

pki_mbedcrypto.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

pki.c

Add safety checks for all ssh_string_fill calls

2021-08-17 15:46:53 +02:00

poll.c

ssh_event_dopoll can also return SSH_AGAIN

2019-02-27 08:17:53 +01:00

scp.c

scp: Do not allow newlines in pushed files names

2019-12-09 16:38:37 +01:00

server.c

server: Use SSH_STRING_FREE()

2019-12-09 16:38:36 +01:00

session.c

session: add missing return value documentation

2020-05-05 14:33:24 +02:00

sftp.c

Correctly parse v4 subsecond timestamps

2020-05-05 14:32:04 +02:00

sftpserver.c

sftpserver: Add missing return check for ssh_buffer_add_data()

2020-06-08 09:15:22 +02:00

socket.c

socket: Fix the error message

2020-01-23 09:50:04 +01:00

string.c

string: Don't allow to allocate strings bigger than 256M

2018-09-04 12:29:20 +02:00

threads.c

threads: Automatically call ssh_init on load

2018-08-03 16:43:03 +02:00

token.c

token: Added function to remove duplicates

2019-07-04 11:26:19 +02:00

wrapper.c

wrapper: Avoid memory leak on errors during key exchange

2021-08-17 15:46:53 +02:00