Dirkjan Bussink f6a2f6190c Ignore request success and failure message if they are not expected ...

In https://gitlab.com/libssh/libssh-mirror/-/merge_requests/145#note_463232084
behavior in libssh was identified where it diverges from how for example
OpenSSH behaves. In OpenSSH if a request success of failure message is
received, apart from it being treated as a keepalive message, it is
ignored otherwise.

Libssh does handle the unexpected message and triggers an error
condition internally. This means that with the Dropbear behavior where
it replies to a hostkeys-00@openssh.com message even with a want_reply
= 0 (arguably a bug), libssh enters an error state.

This change makes the libssh behavior match OpenSSH to ignore these
messages. The spec is a bit unclear on whether Dropbear is buggy here or
not, but let's be liberal with the input accepted here in libssh.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>

2020-12-11 13:29:46 +01:00

..

benchmarks

cmake: Do not use cached LIBSSH_PUBLIC_INCLUDE_DIRS

2019-11-07 14:01:01 +01:00

client

auth: Add ssh_userauth_publickey_auto_get_current_identity()

2020-12-10 09:22:13 +01:00

etc

etc: Adds a new user Charlie

2019-12-20 14:39:56 +01:00

fuzz

fuzz: Extend readme for reproducing and debugging tips

2020-12-08 14:54:25 +01:00

keys

auth: Add ssh_userauth_publickey_auto_get_current_identity()

2020-12-10 09:22:13 +01:00

pkcs11

tests/pkcs11/setup-softhsm-tokens.sh: updates the script to handle LOADPUBLIC parameter.

2020-05-20 12:49:29 +02:00

pkd

tests: Disable *cbc ciphers in Dropbear tests

2020-11-02 16:03:58 +01:00

server

Add initial server algorithm test for no HMAC overlap

2020-10-14 11:07:22 +02:00

unittests

Ignore request success and failure message if they are not expected

2020-12-11 13:29:46 +01:00

chmodtest.c

Added some other junk test file

2010-05-17 20:08:11 +02:00

chroot_wrapper.c

tests: Temporarily build chroot_wrapper

2017-12-15 12:00:49 +01:00

CMakeLists.txt

auth: Add ssh_userauth_publickey_auto_get_current_identity()

2020-12-10 09:22:13 +01:00

cmdline.c

tests: allow conditionnal execution on pattern

2015-02-02 17:34:15 +01:00

ctest-default.cmake

tests: Do not trace sshd

2018-10-19 17:42:55 +02:00

generate.py

A few test cases for benchmarks

2009-11-05 18:18:35 +01:00

ssh_ping.c

Make the testing ping use all supported algorithms

2020-04-20 14:14:33 +02:00

test_socket.c

struct socket -> struct ssh_socket_struct +typedef

2009-12-06 22:48:56 +01:00

tests_config.h.cmake

torture: Added a function to setup a libssh based server

2020-03-29 10:00:57 +02:00

torture_cmocka.c

tests: Define LIBSSH_STATIC for torture_cmocka

2018-09-05 11:43:05 +02:00

torture_cmocka.h

torture: Add assert macros for ssh return codes

2018-06-30 14:37:04 +02:00

torture_key.c

pki: add support for sk-ecdsa and sk-ed25519

2020-02-11 10:08:26 +01:00

torture_key.h

torture_key: Adds public keys in PEM format - as required by p11tool.

2019-12-20 14:40:38 +01:00

torture_pki.c

tests: Include config.h in torture_pki.c

2018-11-27 11:52:12 +01:00

torture_pki.h

tests: Move helper functions to a common file

2018-01-10 22:24:11 +01:00

torture.c

torture: Place additional configuration options before defaults so they can override them

2020-10-14 11:07:14 +02:00

torture.h

tests/torture.c: update the definition of torture_setup_tokens() to take load_public as an option that

2020-05-20 12:49:29 +02:00

valgrind.supp

valgrind: Add suppression for glibc dlopen issue

2016-01-19 11:03:52 +01:00