From 0c427d1154d1385758df5d4fa088a3fddc147f61 Mon Sep 17 00:00:00 2001 From: Visweswara Tanuku Date: Wed, 20 Apr 2022 21:23:03 +0530 Subject: [PATCH] FROMLIST: serial: qcom_geni_serial: Disable MMIO tracing for geni serial Disable MMIO tracing for geni serial driver to prevent excessive logging. Any access over serial console would involve a lot of TX and RX register accesses (and few others), so these MMIO read/write trace events in these drivers cause a lot of unwanted noise because of the high frequency of such operations and it is not very useful tracing these events for such drivers. Given we want to enable these trace events on development devices (maybe not production devices) where performance also really matters so that we don't regress other components by wasting CPU cycles and memory collecting these traces, it makes more sense to disable these traces from such drivers. Also another reason to disable these traces would be to prevent recursive tracing when we display the trace buffer containing these MMIO trace events since writing onto serial console would further record MMIO traces. Cc: Bjorn Andersson Signed-off-by: Sai Prakash Ranjan Bug: 229834709 Link: https://lore.kernel.org/lkml/282f2d8fb795e8b1961693ed4184b8136c3520db.1651663123.git.quic_saipraka@quicinc.com/ Change-Id: Ifac104dceae688b83b15e6a6fd0a0c55eb7b43e5 Signed-off-by: Visweswara Tanuku --- drivers/tty/serial/qcom_geni_serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 5379239bc6eb..467cfd464c3a 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -4,6 +4,9 @@ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. */ +/* Disable MMIO tracing to prevent excessive logging of unwanted MMIO traces */ +#define __DISABLE_TRACE_MMIO__ + #include #include #include