From 11b29ed51b2eb8d8d4361b3f7e76fb48c24aac1e Mon Sep 17 00:00:00 2001 From: Jianxiong Pan Date: Wed, 29 Apr 2020 19:42:38 +0800 Subject: [PATCH] coverity: fix coverity error. [1/1] PD#SWPL-23799 Problem: memory leak. unchecked return value. Solution: free the alloced memory. Verify: build pass. Change-Id: I6d55b582c03bf0f5ac3b871925c8e3f477371137 Signed-off-by: Jianxiong Pan --- drivers/amlogic/media/camera/gc2145_mipi.c | 1 + drivers/amlogic/media/camera/ov5640.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/amlogic/media/camera/gc2145_mipi.c b/drivers/amlogic/media/camera/gc2145_mipi.c index f251ef6a086a..a91f3f02d462 100644 --- a/drivers/amlogic/media/camera/gc2145_mipi.c +++ b/drivers/amlogic/media/camera/gc2145_mipi.c @@ -3105,6 +3105,7 @@ static int gc2145_open(struct file *file) if (retval) { vm_deinit_resource(&(dev->vminfo)); + kfree(fh); return retval; } diff --git a/drivers/amlogic/media/camera/ov5640.c b/drivers/amlogic/media/camera/ov5640.c index ad173684f71b..94cf4fcdc795 100644 --- a/drivers/amlogic/media/camera/ov5640.c +++ b/drivers/amlogic/media/camera/ov5640.c @@ -3097,8 +3097,10 @@ static int ov5640_open(struct file *file) } mutex_unlock(&dev->mutex); - if (retval) + if (retval) { + kfree(fh); return retval; + } #ifdef CONFIG_HAS_WAKELOCK wake_lock(&(dev->wake_lock));