From 120bedb20cbffb20bea7decaecad4688f7f23701 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Mon, 24 Oct 2016 18:42:30 -0200 Subject: [PATCH] UPSTREAM: [media] v4l2-flash-led-class: remove a now unused var commit 079933dbcb02 ("[media] v4l: flash led class: Fix of_node release in probe() error path") removed the need of an ancillary var at the release function, as reported by smatch: drivers/media/v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_release': drivers/media/v4l2-core/v4l2-flash-led-class.c:678:23: warning: variable 'led_cdev' set but not used [-Wunused-but-set-variable] struct led_classdev *led_cdev; ^~~~~~~~ Get rid of it. Fixes: commit 079933dbcb02 ("[media] v4l: flash led class: Fix of_node release in probe() error path") Signed-off-by: Mauro Carvalho Chehab (cherry picked from commit bd676c0c04ec94bd830b9192e2c33f2c4532278d) from media/v4.9-2 BUG=b:62359918 TEST=No regression in camera functionality TEST=Kernel builds and boots Change-Id: Id2d0b84b2f0f5d91efa86c7a63c6b38dd97a1c58 Signed-off-by: Nathan Ciobanu Reviewed-on: https://chromium-review.googlesource.com/528599 Commit-Ready: Nathan D Ciobanu Tested-by: Yong Zhi Reviewed-by: Tomasz Figa Signed-off-by: Jacob Chen --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c index 274c373eea26..500215bd3e39 100644 --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c @@ -682,13 +682,11 @@ EXPORT_SYMBOL_GPL(v4l2_flash_init); void v4l2_flash_release(struct v4l2_flash *v4l2_flash) { struct v4l2_subdev *sd; - struct led_classdev *led_cdev; if (IS_ERR_OR_NULL(v4l2_flash)) return; sd = &v4l2_flash->sd; - led_cdev = &v4l2_flash->fled_cdev->led_cdev; v4l2_async_unregister_subdev(sd);