From 1799a4d1efc028aa8d663c3aae776527328a770b Mon Sep 17 00:00:00 2001 From: Guochun Huang Date: Sat, 25 Dec 2021 11:23:30 +0800 Subject: [PATCH] drm/rockchip/rk628: combtxphy: lvds: power up all channel after phy lock Signed-off-by: Guochun Huang Change-Id: If28520a20e73258037c08cb4dd95888a45093d6a --- drivers/gpu/drm/rockchip/rk628/rk628_combtxphy.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk628/rk628_combtxphy.c b/drivers/gpu/drm/rockchip/rk628/rk628_combtxphy.c index e87f097bdf90..8cdb50cdf122 100644 --- a/drivers/gpu/drm/rockchip/rk628/rk628_combtxphy.c +++ b/drivers/gpu/drm/rockchip/rk628/rk628_combtxphy.c @@ -173,7 +173,7 @@ static int rk628_combtxphy_lvds_power_on(struct rk628_combtxphy *combtxphy) SW_PLL_FRAC_DIV(combtxphy->frac_div) | SW_RATE(combtxphy->rate_div / 2)); regmap_update_bits(combtxphy->regmap, COMBTXPHY_CON0, - SW_PD_PLL | SW_TX_PD_MASK, 0); + SW_PD_PLL, 0); ret = regmap_read_poll_timeout(combtxphy->grf, GRF_DPHY0_STATUS, val, val & DPHY_PHYLOCK, 0, 1000); @@ -184,7 +184,7 @@ static int rk628_combtxphy_lvds_power_on(struct rk628_combtxphy *combtxphy) usleep_range(100, 200); regmap_update_bits(combtxphy->regmap, COMBTXPHY_CON0, - SW_TX_IDLE_MASK, 0); + SW_TX_IDLE_MASK | SW_TX_PD_MASK, 0); return 0; } @@ -477,9 +477,6 @@ static int rk628_combtxphy_probe(struct platform_device *pdev) return ret; } - regmap_write(combtxphy->regmap, COMBTXPHY_CON0, - SW_TX_IDLE(0x3ff) | SW_TX_PD(0x3ff) | SW_PD_PLL); - phy = devm_phy_create(dev, NULL, &rk628_combtxphy_ops); if (IS_ERR(phy)) { ret = PTR_ERR(phy);