shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 12:17:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

phy: rockchip-naneng-usb2: do apb reset during probe

Browse Source 
It's not enough to reset the internal circuit in phy
with the phy power reset signal when probe. It also
needs to reset the apb of phy, with this patch, we
can fix the usb enumeration error on some rv1126/rv1109
products.

Signed-off-by: William Wu <william.wu@rock-chips.com>
Change-Id: Ib6bb0f0aeca7577ad65041a28ede57ba110b7bc0
This commit is contained in:
William Wu
2021-11-02 19:42:06 +08:00
committed by Tao Huang
parent 0deaba2121
commit 1d5173fc2d
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/phy/rockchip/phy-rockchip-naneng-usb2.c
View File

@@ -221,6 +221,7 @@ struct rockchip_usb2phy_port {
* @dev: pointer to our struct device.
* @grf: General Register Files regmap.
* @base: the base address of APB interface.
* @apb_reset: apb reset signal for phy.
* @reset: power reset signal for phy.
* @clks: array of input clocks.
* @num_clks: number of input clocks.
@@ -239,6 +240,7 @@ struct rockchip_usb2phy {
struct device *dev;
struct regmap *grf;
void __iomem *base;
struct reset_control *apb_reset;
struct reset_control *reset;
struct clk_bulk_data *clks;
int num_clks;
@@ -1507,6 +1509,10 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
if (IS_ERR(rphy->reset))
return PTR_ERR(rphy->reset);
rphy->apb_reset = devm_reset_control_get(dev, "u2phy-apb");
if (IS_ERR(rphy->apb_reset))
return PTR_ERR(rphy->apb_reset);
rphy->vup_gpio = devm_gpiod_get_optional(dev, "vup", GPIOD_OUT_LOW);
if (IS_ERR(rphy->vup_gpio)) {
ret = PTR_ERR(rphy->vup_gpio);
@@ -1514,9 +1520,11 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
return ret;
}
reset_control_assert(rphy->apb_reset);
reset_control_assert(rphy->reset);
udelay(1);
reset_control_deassert(rphy->reset);
reset_control_deassert(rphy->apb_reset);
match = of_match_device(dev->driver->of_match_table, dev);
if (!match || !match->data) {