shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

iio: light: al3010: Fix an error handling path in al3010_probe()

Browse Source 
[ Upstream commit a4b7064d34186cf4970fe0333c3b27346cf8f819 ]

If i2c_smbus_write_byte_data() fails in al3010_init(),
al3010_set_pwr(false) is not called.

In order to avoid such a situation, move the devm_add_action_or_reset()
witch calls al3010_set_pwr(false) right after a successful
al3010_set_pwr(true).

Fixes: c36b5195ab ("iio: light: add Dyna-Image AL3010 driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/ee5d10a2dd2b70f29772d5df33774d3974a80f30.1725993353.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET
2024-09-10 20:36:06 +02:00
committed by Greg Kroah-Hartman
parent 7d338cee86
commit 2dc9845228
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/iio/light/al3010.c
View File

@@ -87,7 +87,12 @@ static int al3010_init(struct al3010_data *data)
int ret; int ret;
ret = al3010_set_pwr(data->client, true); ret = al3010_set_pwr(data->client, true);
if (ret < 0)
return ret;
ret = devm_add_action_or_reset(&data->client->dev,
al3010_set_pwr_off,
data);
if (ret < 0) if (ret < 0)
return ret; return ret;
@@ -191,12 +196,6 @@ static int al3010_probe(struct i2c_client *client,
return ret; return ret;
} }
ret = devm_add_action_or_reset(&client->dev,
al3010_set_pwr_off,
data);
if (ret < 0)
return ret;
return devm_iio_device_register(&client->dev, indio_dev); return devm_iio_device_register(&client->dev, indio_dev);
} }