From 35455634f9d5a40ff731933535341d7cb9762ca1 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Sat, 14 Sep 2024 14:36:51 +0000 Subject: [PATCH] Revert "leds: trigger: Call synchronize_rcu() before calling trig->activate()" This reverts commit c3f8e2ec3c7b7d77c6dc7f288b3555fa9f6a4f24 which is commit b1bbd20f35e19774ea01989320495e09ac44fba3 upstream. It breaks the Android kernel abi and can be brought back in the future in an abi-safe way if it is really needed. Bug: 161946584 Change-Id: I3c84527151f1018837dce6c1c77756ae4909da8e Signed-off-by: Greg Kroah-Hartman --- drivers/leds/led-triggers.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index fe7fb2e7149c..cdb446cb84af 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -193,13 +193,6 @@ int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) spin_unlock(&trig->leddev_list_lock); led_cdev->trigger = trig; - /* - * Some activate() calls use led_trigger_event() to initialize - * the brightness of the LED for which the trigger is being set. - * Ensure the led_cdev is visible on trig->led_cdevs for this. - */ - synchronize_rcu(); - ret = 0; if (trig->activate) ret = trig->activate(led_cdev);