From 35a6ba5aa97385f81ca38361a3e6bd6a2b4b1ceb Mon Sep 17 00:00:00 2001 From: Jianqun Xu Date: Thu, 16 Jun 2022 16:52:52 +0800 Subject: [PATCH] gpio/rockchip: avoid division by zero If the clk_get_rate return '0', it will happen division by zero. Signed-off-by: Jianqun Xu Change-Id: I1d2c6b12b961a78629f22496fe8f8b685b27dc09 --- drivers/gpio/gpio-rockchip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index aceef0a21089..77c3f6f22ca9 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -199,8 +199,10 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc, if (bank->gpio_type == GPIO_TYPE_V2 && !IS_ERR(bank->db_clk)) { div_debounce_support = true; freq = clk_get_rate(bank->db_clk); + if (!freq) + return -EINVAL; max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq; - if (debounce > max_debounce) + if ((unsigned long)debounce > max_debounce) return -EINVAL; div = debounce * freq;