diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index fc8a8c09a56b..42bd1bcaa3b5 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -1007,12 +1007,10 @@ static enum rx_handler_result handle_not_macsec(struct sk_buff *skb) struct metadata_dst *md_dst; struct macsec_rxh_data *rxd; struct macsec_dev *macsec; - bool is_macsec_md_dst; rcu_read_lock(); rxd = macsec_data_rcu(skb->dev); md_dst = skb_metadata_dst(skb); - is_macsec_md_dst = md_dst && md_dst->type == METADATA_MACSEC; list_for_each_entry_rcu(macsec, &rxd->secys, secys) { struct sk_buff *nskb; @@ -1023,42 +1021,10 @@ static enum rx_handler_result handle_not_macsec(struct sk_buff *skb) * the SecTAG, so we have to deduce which port to deliver to. */ if (macsec_is_offloaded(macsec) && netif_running(ndev)) { - const struct macsec_ops *ops; - - ops = macsec_get_ops(macsec, NULL); - - if (ops->rx_uses_md_dst && !is_macsec_md_dst) + if (md_dst && md_dst->type == METADATA_MACSEC && + (!find_rx_sc(&macsec->secy, md_dst->u.macsec_info.sci))) continue; - if (is_macsec_md_dst) { - struct macsec_rx_sc *rx_sc; - - /* All drivers that implement MACsec offload - * support using skb metadata destinations must - * indicate that they do so. - */ - DEBUG_NET_WARN_ON_ONCE(!ops->rx_uses_md_dst); - rx_sc = find_rx_sc(&macsec->secy, - md_dst->u.macsec_info.sci); - if (!rx_sc) - continue; - /* device indicated macsec offload occurred */ - skb->dev = ndev; - skb->pkt_type = PACKET_HOST; - eth_skb_pkt_type(skb, ndev); - ret = RX_HANDLER_ANOTHER; - goto out; - } - - /* This datapath is insecure because it is unable to - * enforce isolation of broadcast/multicast traffic and - * unicast traffic with promiscuous mode on the macsec - * netdev. Since the core stack has no mechanism to - * check that the hardware did indeed receive MACsec - * traffic, it is possible that the response handling - * done by the MACsec port was to a plaintext packet. - * This violates the MACsec protocol standard. - */ if (ether_addr_equal_64bits(hdr->h_dest, ndev->dev_addr)) { /* exact match, divert skb to this port */ @@ -1074,7 +1040,11 @@ static enum rx_handler_result handle_not_macsec(struct sk_buff *skb) break; nskb->dev = ndev; - eth_skb_pkt_type(nskb, ndev); + if (ether_addr_equal_64bits(hdr->h_dest, + ndev->broadcast)) + nskb->pkt_type = PACKET_BROADCAST; + else + nskb->pkt_type = PACKET_MULTICAST; __netif_rx(nskb); }