shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

soc: qcom: pdr: protect locator_addr with the main mutex

Browse Source 
[ Upstream commit 107924c14e3ddd85119ca43c26a4ee1056fa9b84 ]

If the service locator server is restarted fast enough, the PDR can
rewrite locator_addr fields concurrently. Protect them by placing
modification of those fields under the main pdr->lock.

Fixes: fbe639b44a ("soc: qcom: Introduce Protection Domain Restart helpers")
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Steev Klimaszewski <steev@kali.org>
Tested-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240622-qcom-pd-mapper-v9-1-a84ee3591c8e@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dmitry Baryshkov
2024-06-22 01:03:40 +03:00
committed by Greg Kroah-Hartman
parent f36a298e1e
commit 475a77fb3f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/soc/qcom/pdr_interface.c
View File

@@ -76,12 +76,12 @@ static int pdr_locator_new_server(struct qmi_handle *qmi,
locator_hdl); locator_hdl);
struct pdr_service *pds; struct pdr_service *pds;
mutex_lock(&pdr->lock);
/* Create a local client port for QMI communication */ /* Create a local client port for QMI communication */
pdr->locator_addr.sq_family = AF_QIPCRTR; pdr->locator_addr.sq_family = AF_QIPCRTR;
pdr->locator_addr.sq_node = svc->node; pdr->locator_addr.sq_node = svc->node;
pdr->locator_addr.sq_port = svc->port; pdr->locator_addr.sq_port = svc->port;
mutex_lock(&pdr->lock);
pdr->locator_init_complete = true; pdr->locator_init_complete = true;
mutex_unlock(&pdr->lock); mutex_unlock(&pdr->lock);
@@ -104,10 +104,10 @@ static void pdr_locator_del_server(struct qmi_handle *qmi,
mutex_lock(&pdr->lock); mutex_lock(&pdr->lock);
pdr->locator_init_complete = false; pdr->locator_init_complete = false;
mutex_unlock(&pdr->lock);
pdr->locator_addr.sq_node = 0; pdr->locator_addr.sq_node = 0;
pdr->locator_addr.sq_port = 0; pdr->locator_addr.sq_port = 0;
mutex_unlock(&pdr->lock);
} }
static const struct qmi_ops pdr_locator_ops = { static const struct qmi_ops pdr_locator_ops = {
@@ -365,12 +365,14 @@ static int pdr_get_domain_list(struct servreg_get_domain_list_req *req,
if (ret < 0) if (ret < 0)
return ret; return ret;
mutex_lock(&pdr->lock);
ret = qmi_send_request(&pdr->locator_hdl, ret = qmi_send_request(&pdr->locator_hdl,
&pdr->locator_addr, &pdr->locator_addr,
&txn, SERVREG_GET_DOMAIN_LIST_REQ, &txn, SERVREG_GET_DOMAIN_LIST_REQ,
SERVREG_GET_DOMAIN_LIST_REQ_MAX_LEN, SERVREG_GET_DOMAIN_LIST_REQ_MAX_LEN,
servreg_get_domain_list_req_ei, servreg_get_domain_list_req_ei,
req); req);
mutex_unlock(&pdr->lock);
if (ret < 0) { if (ret < 0) {
qmi_txn_cancel(&txn); qmi_txn_cancel(&txn);
return ret; return ret;