From 4df9208b4e93147c253d41f1f1a0c1152d4831d3 Mon Sep 17 00:00:00 2001 From: Tao Huang Date: Wed, 27 Jul 2022 09:29:09 +0800 Subject: [PATCH] drm/rockchip: drv: Fix drm_atomic_helper_duplicate_state() error check Use IS_ERR() instead of checking for a NULL pointer when calling for drm_atomic_helper_duplicate_state() failures. drm_atomic_helper_duplicate_state() return an ERR_PTR()-encoded error code on failure. Signed-off-by: Tao Huang Change-Id: I95388698239a7e1bd2bfbedd2bd921bbf52372f0 --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 021af6128b85..fd8da57c2cf6 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -1167,7 +1167,7 @@ static void rockchip_drm_set_property_default(struct drm_device *drm) drm_modeset_lock_all(drm); state = drm_atomic_helper_duplicate_state(drm, conf->acquire_ctx); - if (!state) { + if (IS_ERR(state)) { DRM_ERROR("failed to alloc atomic state\n"); goto err_unlock; }