From 5244d0ec1b02cbf3f920bdb6acfc013fd165a935 Mon Sep 17 00:00:00 2001 From: Yiqing Zeng Date: Thu, 30 Jun 2022 21:07:43 +0800 Subject: [PATCH] media: i2c: ov7251 support 640x480@120fps Signed-off-by: Yiqing Zeng Change-Id: I7d70f6d7f88079fd5242586b084724312adfb0aa --- drivers/media/i2c/ov7251.c | 2085 +++++++++++++++++++++--------------- 1 file changed, 1196 insertions(+), 889 deletions(-) diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c index 0c10203f822b..462b5aa38de2 100644 --- a/drivers/media/i2c/ov7251.c +++ b/drivers/media/i2c/ov7251.c @@ -1,110 +1,307 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Driver for the OV7251 camera sensor. + * ov7251 driver * - * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. - * Copyright (c) 2017-2018, Linaro Ltd. + * Copyright (C) 2020 Rockchip Electronics Co., Ltd. + * + * V0.0X01.0X01 first version */ -#include +//#define DEBUG #include -#include #include +#include #include #include -#include #include +#include #include +#include #include -#include +#include +#include +#include +#include +#include #include -#include #include +#include -#define OV7251_SC_MODE_SELECT 0x0100 -#define OV7251_SC_MODE_SELECT_SW_STANDBY 0x0 -#define OV7251_SC_MODE_SELECT_STREAMING 0x1 +#define DRIVER_VERSION KERNEL_VERSION(0, 0x01, 0x01) -#define OV7251_CHIP_ID_HIGH 0x300a -#define OV7251_CHIP_ID_HIGH_BYTE 0x77 -#define OV7251_CHIP_ID_LOW 0x300b -#define OV7251_CHIP_ID_LOW_BYTE 0x50 -#define OV7251_SC_GP_IO_IN1 0x3029 -#define OV7251_AEC_EXPO_0 0x3500 -#define OV7251_AEC_EXPO_1 0x3501 -#define OV7251_AEC_EXPO_2 0x3502 -#define OV7251_AEC_AGC_ADJ_0 0x350a -#define OV7251_AEC_AGC_ADJ_1 0x350b -#define OV7251_TIMING_FORMAT1 0x3820 -#define OV7251_TIMING_FORMAT1_VFLIP BIT(2) -#define OV7251_TIMING_FORMAT2 0x3821 -#define OV7251_TIMING_FORMAT2_MIRROR BIT(2) -#define OV7251_PRE_ISP_00 0x5e00 -#define OV7251_PRE_ISP_00_TEST_PATTERN BIT(7) +#ifndef V4L2_CID_DIGITAL_GAIN +#define V4L2_CID_DIGITAL_GAIN V4L2_CID_GAIN +#endif -struct reg_value { - u16 reg; +#define OV7251_LANES 1 +#define OV7251_BITS_PER_SAMPLE 10 +#define OV7251_LINK_FREQ_240 240000000 + +#define PIXEL_RATE_WITH_240M_10BIT (OV7251_LINK_FREQ_240 * 2 * \ + OV7251_LANES / OV7251_BITS_PER_SAMPLE) +#define OV7251_XVCLK_FREQ 24000000 + +#define CHIP_ID 0x77 +#define OV7251_REG_CHIP_ID 0x300a +#define OV7251_REG_MOD_VENDOR_ID 0x3d10 +#define OV7251_REG_OPT_LOAD_CTRL 0x3d81 + +#define OV7251_REG_CTRL_MODE 0x0100 +#define OV7251_MODE_SW_STANDBY 0x0 +#define OV7251_MODE_STREAMING BIT(0) + +#define OV7251_REG_EXPOSURE 0x3500 +#define OV7251_EXPOSURE_MIN 4 +#define OV7251_EXPOSURE_STEP 0xf +#define OV7251_VTS_MAX 0xffff + +#define OV7251_REG_ANALOG_GAIN 0x350a +#define ANALOG_GAIN_MASK 0x3ff +#define ANALOG_GAIN_MIN 0x10 +#define ANALOG_GAIN_MAX 0x3e0 +#define ANALOG_GAIN_STEP 1 +#define ANALOG_GAIN_DEFAULT 0x20 + +#define OV7251_REG_TEST_PATTERN 0x5e00 +#define OV7251_TEST_PATTERN_ENABLE 0x80 +#define OV7251_TEST_PATTERN_DISABLE 0x0 + +#define OV7251_REG_VTS 0x380e + +#define OV7251_MIRROR_REG 0x3821 +#define OV7251_FLIP_REG 0x3820 + +#define OV7251_FETCH_MIRROR(VAL, ENABLE) (ENABLE ? VAL | 0x01 : VAL & 0xf9) +#define OV7251_FETCH_FLIP(VAL, ENABLE) (ENABLE ? VAL | 0x01 : VAL & 0x9f) + +#define REG_DELAY 0xFFFE +#define REG_NULL 0xFFFF + +#define OV7251_REG_VALUE_08BIT 1 +#define OV7251_REG_VALUE_16BIT 2 +#define OV7251_REG_VALUE_24BIT 3 + +#define OF_CAMERA_PINCTRL_STATE_DEFAULT "rockchip,camera_default" +#define OF_CAMERA_PINCTRL_STATE_SLEEP "rockchip,camera_sleep" +#define OV7251_NAME "ov7251" + +static const char * const ov7251_supply_names[] = { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ + "dvdd", /* Digital core power */ +}; + +#define OV7251_NUM_SUPPLIES ARRAY_SIZE(ov7251_supply_names) + +struct regval { + u16 addr; u8 val; }; -struct ov7251_mode_info { +struct ov7251_mode { + u32 bus_fmt; u32 width; u32 height; - const struct reg_value *data; - u32 data_size; - u32 pixel_clock; - u32 link_freq; - u16 exposure_max; - u16 exposure_def; - struct v4l2_fract timeperframe; + struct v4l2_fract max_fps; + u32 hts_def; + u32 vts_def; + u32 exp_def; + const struct regval *reg_list; + u32 hdr_mode; + u32 vc[PAD_MAX]; }; struct ov7251 { - struct i2c_client *i2c_client; - struct device *dev; - struct v4l2_subdev sd; - struct media_pad pad; - struct v4l2_fwnode_endpoint ep; - struct v4l2_mbus_framefmt fmt; - struct v4l2_rect crop; - struct clk *xclk; - u32 xclk_freq; + struct i2c_client *client; + struct clk *xvclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *pwdn_gpio; + struct regulator_bulk_data supplies[OV7251_NUM_SUPPLIES]; - struct regulator *io_regulator; - struct regulator *core_regulator; - struct regulator *analog_regulator; + struct pinctrl *pinctrl; + struct pinctrl_state *pins_default; + struct pinctrl_state *pins_sleep; - const struct ov7251_mode_info *current_mode; - - struct v4l2_ctrl_handler ctrls; - struct v4l2_ctrl *pixel_clock; - struct v4l2_ctrl *link_freq; - struct v4l2_ctrl *exposure; - struct v4l2_ctrl *gain; - - /* Cached register values */ - u8 aec_pk_manual; - u8 pre_isp_00; - u8 timing_format1; - u8 timing_format2; - - struct mutex lock; /* lock to protect power state, ctrls and mode */ - bool power_on; - - struct gpio_desc *enable_gpio; + struct v4l2_subdev subdev; + struct media_pad pad; + struct v4l2_ctrl_handler ctrl_handler; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *anal_gain; + struct v4l2_ctrl *digi_gain; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *test_pattern; + struct mutex mutex; + bool streaming; + bool power_on; + const struct ov7251_mode *cur_mode; + struct v4l2_fract cur_fps; + u32 module_index; + const char *module_facing; + const char *module_name; + const char *len_name; + u32 cur_vts; }; -static inline struct ov7251 *to_ov7251(struct v4l2_subdev *sd) -{ - return container_of(sd, struct ov7251, sd); -} +#define to_ov7251(sd) container_of(sd, struct ov7251, subdev) -static const struct reg_value ov7251_global_init_setting[] = { - { 0x0103, 0x01 }, - { 0x303b, 0x02 }, +/* + * Xclk 24Mhz + */ +static const struct regval ov7251_global_regs[] = { + {REG_NULL, 0x00}, }; -static const struct reg_value ov7251_setting_vga_30fps[] = { + +static __maybe_unused const struct regval ov7251_640x480_120fps_regs[] = { + {0x0103, 0x01}, + {0x0100, 0x00}, + {0x3005, 0x00}, + {0x3012, 0xc0}, + {0x3013, 0xd2}, + {0x3014, 0x04}, + {0x3016, 0x10}, + {0x3017, 0x00}, + {0x3018, 0x00}, + {0x301a, 0x00}, + {0x301b, 0x00}, + {0x301c, 0x00}, + {0x3023, 0x05}, + {0x3037, 0xf0}, + {0x3098, 0x04}, + {0x3099, 0x32}, + {0x309a, 0x05}, + {0x309b, 0x04}, + {0x30b0, 0x0a}, + {0x30b1, 0x01}, + {0x30b3, 0x64}, + {0x30b4, 0x03}, + {0x30b5, 0x05}, + {0x3106, 0xda}, + {0x3500, 0x00}, + {0x3501, 0x1f}, + {0x3502, 0x80}, + {0x3503, 0x07}, + {0x3509, 0x10}, + {0x350b, 0x10}, + {0x3600, 0x1c}, + {0x3602, 0x62}, + {0x3620, 0xb7}, + {0x3622, 0x04}, + {0x3626, 0x21}, + {0x3627, 0x30}, + {0x3630, 0x44}, + {0x3631, 0x35}, + {0x3634, 0x60}, + {0x3636, 0x00}, + {0x3662, 0x01}, + {0x3663, 0x70}, + {0x3664, 0xf0}, + {0x3666, 0x0a}, + {0x3669, 0x1a}, + {0x366a, 0x00}, + {0x366b, 0x50}, + {0x3673, 0x01}, + {0x3674, 0xef}, + {0x3675, 0x03}, + {0x3705, 0xc1}, + {0x3709, 0x40}, + {0x373c, 0x08}, + {0x3742, 0x00}, + {0x3757, 0xb3}, + {0x3788, 0x00}, + {0x37a8, 0x01}, + {0x37a9, 0xc0}, + {0x3800, 0x00}, + {0x3801, 0x04}, + {0x3802, 0x00}, + {0x3803, 0x04}, + {0x3804, 0x02}, + {0x3805, 0x8b}, + {0x3806, 0x01}, + {0x3807, 0xeb}, + {0x3808, 0x02}, + {0x3809, 0x80}, + {0x380a, 0x01}, + {0x380b, 0xe0}, + {0x380c, 0x03}, + {0x380d, 0xa1}, + {0x380e, 0x02}, + {0x380f, 0x1a}, + {0x3810, 0x00}, + {0x3811, 0x04}, + {0x3812, 0x00}, + {0x3813, 0x05}, + {0x3814, 0x11}, + {0x3815, 0x11}, + {0x3820, 0x40}, + {0x3821, 0x00}, + {0x382f, 0x0e}, + {0x3832, 0x00}, + {0x3833, 0x05}, + {0x3834, 0x00}, + {0x3835, 0x0c}, + {0x3837, 0x00}, + {0x3b80, 0x00}, + {0x3b81, 0xa5}, + {0x3b82, 0x10}, + {0x3b83, 0x00}, + {0x3b84, 0x08}, + {0x3b85, 0x00}, + {0x3b86, 0x01}, + {0x3b87, 0x00}, + {0x3b88, 0x00}, + {0x3b89, 0x00}, + {0x3b8a, 0x00}, + {0x3b8b, 0x05}, + {0x3b8c, 0x00}, + {0x3b8d, 0x00}, + {0x3b8e, 0x00}, + {0x3b8f, 0x1a}, + {0x3b94, 0x05}, + {0x3b95, 0xf2}, + {0x3b96, 0x40}, + {0x3c00, 0x89}, + {0x3c01, 0x63}, + {0x3c02, 0x01}, + {0x3c03, 0x00}, + {0x3c04, 0x00}, + {0x3c05, 0x03}, + {0x3c06, 0x00}, + {0x3c07, 0x06}, + {0x3c0c, 0x01}, + {0x3c0d, 0xd0}, + {0x3c0e, 0x02}, + {0x3c0f, 0x0a}, + {0x4001, 0x42}, + {0x4004, 0x04}, + {0x4005, 0x00}, + {0x404e, 0x01}, + {0x4300, 0xff}, + {0x4301, 0x00}, + {0x4501, 0x48}, + {0x4600, 0x00}, + {0x4601, 0x4e}, + {0x4801, 0x0f}, + {0x4806, 0x0f}, + {0x4819, 0xaa}, + {0x4823, 0x3e}, + {0x4837, 0x19}, + {0x4a0d, 0x00}, + {0x4a47, 0x7f}, + {0x4a49, 0xf0}, + {0x4a4b, 0x30}, + {0x5000, 0x85}, + {0x5001, 0x80}, + {REG_NULL, 0x00}, +}; + +/* + * Xclk 24Mhz + * max_framerate 30fps + * mipi_datarate per lane 630Mbps, 2lane + */ +static __maybe_unused const struct regval ov7251_setting_vga_30fps[] = { { 0x3005, 0x00 }, { 0x3012, 0xc0 }, { 0x3013, 0xd2 }, @@ -240,9 +437,10 @@ static const struct reg_value ov7251_setting_vga_30fps[] = { { 0x4a4b, 0x30 }, { 0x5000, 0x85 }, { 0x5001, 0x80 }, + {REG_NULL, 0x00 }, }; -static const struct reg_value ov7251_setting_vga_60fps[] = { +static __maybe_unused const struct regval ov7251_setting_vga_60fps[] = { { 0x3005, 0x00 }, { 0x3012, 0xc0 }, { 0x3013, 0xd2 }, @@ -378,9 +576,10 @@ static const struct reg_value ov7251_setting_vga_60fps[] = { { 0x4a4b, 0x30 }, { 0x5000, 0x85 }, { 0x5001, 0x80 }, + {REG_NULL, 0x00 }, }; -static const struct reg_value ov7251_setting_vga_90fps[] = { +static __maybe_unused const struct regval ov7251_setting_vga_90fps[] = { { 0x3005, 0x00 }, { 0x3012, 0xc0 }, { 0x3013, 0xd2 }, @@ -516,954 +715,1036 @@ static const struct reg_value ov7251_setting_vga_90fps[] = { { 0x4a4b, 0x30 }, { 0x5000, 0x85 }, { 0x5001, 0x80 }, + {REG_NULL, 0x00 }, }; -static const s64 link_freq[] = { - 240000000, -}; - -static const struct ov7251_mode_info ov7251_mode_info_data[] = { +static const struct ov7251_mode supported_modes[] = { { .width = 640, .height = 480, - .data = ov7251_setting_vga_30fps, - .data_size = ARRAY_SIZE(ov7251_setting_vga_30fps), - .pixel_clock = 48000000, - .link_freq = 0, /* an index in link_freq[] */ - .exposure_max = 1704, - .exposure_def = 504, - .timeperframe = { - .numerator = 100, - .denominator = 3000 - } - }, - { - .width = 640, - .height = 480, - .data = ov7251_setting_vga_60fps, - .data_size = ARRAY_SIZE(ov7251_setting_vga_60fps), - .pixel_clock = 48000000, - .link_freq = 0, /* an index in link_freq[] */ - .exposure_max = 840, - .exposure_def = 504, - .timeperframe = { - .numerator = 100, - .denominator = 6014 - } - }, - { - .width = 640, - .height = 480, - .data = ov7251_setting_vga_90fps, - .data_size = ARRAY_SIZE(ov7251_setting_vga_90fps), - .pixel_clock = 48000000, - .link_freq = 0, /* an index in link_freq[] */ - .exposure_max = 552, - .exposure_def = 504, - .timeperframe = { - .numerator = 100, - .denominator = 9043 - } - }, + .max_fps = { + .numerator = 10000, + .denominator = 1200000, + }, + .exp_def = 0x00f8, + .hts_def = 0x03a1, + .vts_def = 0x021a, + .bus_fmt = MEDIA_BUS_FMT_SBGGR10_1X10, + .reg_list = ov7251_640x480_120fps_regs, + .hdr_mode = NO_HDR, + .vc[PAD0] = V4L2_MBUS_CSI2_CHANNEL_0, + } }; -static int ov7251_regulators_enable(struct ov7251 *ov7251) +static const s64 link_freq_menu_items[] = { + OV7251_LINK_FREQ_240 +}; + +static const char * const ov7251_test_pattern_menu[] = { + "Disabled", + "Vertical Color Bar Type 1", + "Vertical Color Bar Type 2", + "Vertical Color Bar Type 3", + "Vertical Color Bar Type 4" +}; + +/* Write registers up to 4 at a time */ +static int ov7251_write_reg(struct i2c_client *client, u16 reg, + u32 len, u32 val) { + u32 buf_i, val_i; + u8 buf[6]; + u8 *val_p; + __be32 val_be; + + if (len > 4) + return -EINVAL; + + buf[0] = reg >> 8; + buf[1] = reg & 0xff; + + val_be = cpu_to_be32(val); + val_p = (u8 *)&val_be; + buf_i = 2; + val_i = 4 - len; + + while (val_i < 4) + buf[buf_i++] = val_p[val_i++]; + + if (i2c_master_send(client, buf, len + 2) != len + 2) + return -EIO; + return 0; +} + +static int ov7251_write_array(struct i2c_client *client, + const struct regval *regs) +{ + u32 i; + int ret = 0; + + for (i = 0; ret == 0 && regs[i].addr != REG_NULL; i++) { + ret = ov7251_write_reg(client, regs[i].addr, + OV7251_REG_VALUE_08BIT, regs[i].val); + } + return ret; +} + +/* Read registers up to 4 at a time */ +static int ov7251_read_reg(struct i2c_client *client, u16 reg, unsigned int len, + u32 *val) +{ + struct i2c_msg msgs[2]; + u8 *data_be_p; + __be32 data_be = 0; + __be16 reg_addr_be = cpu_to_be16(reg); int ret; - /* OV7251 power up sequence requires core regulator - * to be enabled not earlier than io regulator - */ + if (len > 4 || !len) + return -EINVAL; - ret = regulator_enable(ov7251->io_regulator); - if (ret < 0) { - dev_err(ov7251->dev, "set io voltage failed\n"); - return ret; - } + data_be_p = (u8 *)&data_be; + /* Write register address */ + msgs[0].addr = client->addr; + msgs[0].flags = 0; + msgs[0].len = 2; + msgs[0].buf = (u8 *)®_addr_be; - ret = regulator_enable(ov7251->analog_regulator); - if (ret) { - dev_err(ov7251->dev, "set analog voltage failed\n"); - goto err_disable_io; - } + /* Read data from register */ + msgs[1].addr = client->addr; + msgs[1].flags = I2C_M_RD; + msgs[1].len = len; + msgs[1].buf = &data_be_p[4 - len]; - ret = regulator_enable(ov7251->core_regulator); - if (ret) { - dev_err(ov7251->dev, "set core voltage failed\n"); - goto err_disable_analog; - } + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); + if (ret != ARRAY_SIZE(msgs)) + return -EIO; + + *val = be32_to_cpu(data_be); return 0; +} -err_disable_analog: - regulator_disable(ov7251->analog_regulator); -err_disable_io: - regulator_disable(ov7251->io_regulator); + +static int ov7251_get_reso_dist(const struct ov7251_mode *mode, + struct v4l2_mbus_framefmt *framefmt) +{ + return abs(mode->width - framefmt->width) + + abs(mode->height - framefmt->height); +} + +static const struct ov7251_mode * +ov7251_find_best_fit(struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *framefmt = &fmt->format; + int dist; + int cur_best_fit = 0; + int cur_best_fit_dist = -1; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(supported_modes); i++) { + dist = ov7251_get_reso_dist(&supported_modes[i], framefmt); + if (cur_best_fit_dist == -1 || dist < cur_best_fit_dist) { + cur_best_fit_dist = dist; + cur_best_fit = i; + } + } + + return &supported_modes[cur_best_fit]; +} + +static int ov7251_set_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_format *fmt) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + const struct ov7251_mode *mode; + s64 h_blank, vblank_def; + + mutex_lock(&ov7251->mutex); + + mode = ov7251_find_best_fit(fmt); + fmt->format.code = mode->bus_fmt; + fmt->format.width = mode->width; + fmt->format.height = mode->height; + fmt->format.field = V4L2_FIELD_NONE; + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API + *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format; +#else + mutex_unlock(&ov7251->mutex); + return -ENOTTY; +#endif + } else { + ov7251->cur_mode = mode; + h_blank = mode->hts_def - mode->width; + __v4l2_ctrl_modify_range(ov7251->hblank, h_blank, + h_blank, 1, h_blank); + vblank_def = mode->vts_def - mode->height; + __v4l2_ctrl_modify_range(ov7251->vblank, vblank_def, + OV7251_VTS_MAX - mode->height, + 1, vblank_def); + ov7251->cur_fps = mode->max_fps; + } + + mutex_unlock(&ov7251->mutex); + + return 0; +} + +static int ov7251_get_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_format *fmt) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + const struct ov7251_mode *mode = ov7251->cur_mode; + + mutex_lock(&ov7251->mutex); + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API + fmt->format = *v4l2_subdev_get_try_format(sd, cfg, fmt->pad); +#else + mutex_unlock(&ov7251->mutex); + return -ENOTTY; +#endif + } else { + fmt->format.width = mode->width; + fmt->format.height = mode->height; + fmt->format.code = mode->bus_fmt; + fmt->format.field = V4L2_FIELD_NONE; + /* format info: width/height/data type/virctual channel */ + if (fmt->pad < PAD_MAX && mode->hdr_mode != NO_HDR) + fmt->reserved[0] = mode->vc[fmt->pad]; + else + fmt->reserved[0] = mode->vc[PAD0]; + } + mutex_unlock(&ov7251->mutex); + + return 0; +} + +static int ov7251_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_mbus_code_enum *code) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + + if (code->index != 0) + return -EINVAL; + code->code = ov7251->cur_mode->bus_fmt; + + return 0; +} + +static int ov7251_enum_frame_sizes(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_size_enum *fse) +{ + if (fse->index >= ARRAY_SIZE(supported_modes)) + return -EINVAL; + + if (fse->code != supported_modes[0].bus_fmt) + return -EINVAL; + + fse->min_width = supported_modes[fse->index].width; + fse->max_width = supported_modes[fse->index].width; + fse->max_height = supported_modes[fse->index].height; + fse->min_height = supported_modes[fse->index].height; + + return 0; +} + +static int ov7251_enable_test_pattern(struct ov7251 *ov7251, u32 pattern) +{ + u32 val; + + if (pattern) + val = (pattern - 1) | OV7251_TEST_PATTERN_ENABLE; + else + val = OV7251_TEST_PATTERN_DISABLE; + + return ov7251_write_reg(ov7251->client, OV7251_REG_TEST_PATTERN, + OV7251_REG_VALUE_08BIT, val); +} + +static int ov7251_g_frame_interval(struct v4l2_subdev *sd, + struct v4l2_subdev_frame_interval *fi) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + const struct ov7251_mode *mode = ov7251->cur_mode; + + mutex_lock(&ov7251->mutex); + if (ov7251->streaming) + fi->interval = ov7251->cur_fps; + else + fi->interval = mode->max_fps; + mutex_unlock(&ov7251->mutex); + + return 0; +} + +static int ov7251_g_mbus_config(struct v4l2_subdev *sd, + unsigned int pad_id, + struct v4l2_mbus_config *config) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + const struct ov7251_mode *mode = ov7251->cur_mode; + u32 val = 1 << (OV7251_LANES - 1) | + V4L2_MBUS_CSI2_CHANNEL_0 | + V4L2_MBUS_CSI2_CONTINUOUS_CLOCK; + + if (mode->hdr_mode != NO_HDR) + val |= V4L2_MBUS_CSI2_CHANNEL_1; + if (mode->hdr_mode == HDR_X3) + val |= V4L2_MBUS_CSI2_CHANNEL_2; + + config->type = V4L2_MBUS_CSI2_DPHY; + config->flags = val; + + return 0; +} + +static void ov7251_get_module_inf(struct ov7251 *ov7251, + struct rkmodule_inf *inf) +{ + memset(inf, 0, sizeof(*inf)); + strscpy(inf->base.sensor, OV7251_NAME, sizeof(inf->base.sensor)); + strscpy(inf->base.module, ov7251->module_name, + sizeof(inf->base.module)); + strscpy(inf->base.lens, ov7251->len_name, sizeof(inf->base.lens)); +} + +static long ov7251_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + struct rkmodule_hdr_cfg *hdr; + u32 i, h, w; + long ret = 0; + u32 stream = 0; + + switch (cmd) { + case RKMODULE_GET_MODULE_INFO: + ov7251_get_module_inf(ov7251, (struct rkmodule_inf *)arg); + break; + case RKMODULE_GET_HDR_CFG: + hdr = (struct rkmodule_hdr_cfg *)arg; + hdr->esp.mode = HDR_NORMAL_VC; + hdr->hdr_mode = ov7251->cur_mode->hdr_mode; + break; + case RKMODULE_SET_HDR_CFG: + hdr = (struct rkmodule_hdr_cfg *)arg; + w = ov7251->cur_mode->width; + h = ov7251->cur_mode->height; + for (i = 0; i < ARRAY_SIZE(supported_modes); i++) { + if (w == supported_modes[i].width && + h == supported_modes[i].height && + supported_modes[i].hdr_mode == hdr->hdr_mode) { + ov7251->cur_mode = &supported_modes[i]; + break; + } + } + if (i == ARRAY_SIZE(supported_modes)) { + dev_err(&ov7251->client->dev, + "not find hdr mode:%d %dx%d config\n", + hdr->hdr_mode, w, h); + ret = -EINVAL; + } else { + w = ov7251->cur_mode->hts_def - ov7251->cur_mode->width; + h = ov7251->cur_mode->vts_def - ov7251->cur_mode->height; + __v4l2_ctrl_modify_range(ov7251->hblank, w, w, 1, w); + __v4l2_ctrl_modify_range(ov7251->vblank, h, + OV7251_VTS_MAX - ov7251->cur_mode->height, 1, h); + } + break; + case PREISP_CMD_SET_HDRAE_EXP: + break; + case RKMODULE_SET_QUICK_STREAM: + + stream = *((u32 *)arg); + + if (stream) + ret = ov7251_write_reg(ov7251->client, OV7251_REG_CTRL_MODE, + OV7251_REG_VALUE_08BIT, OV7251_MODE_STREAMING); + else + ret = ov7251_write_reg(ov7251->client, OV7251_REG_CTRL_MODE, + OV7251_REG_VALUE_08BIT, OV7251_MODE_SW_STANDBY); + break; + default: + ret = -ENOIOCTLCMD; + break; + } return ret; } -static void ov7251_regulators_disable(struct ov7251 *ov7251) +#ifdef CONFIG_COMPAT +static long ov7251_compat_ioctl32(struct v4l2_subdev *sd, + unsigned int cmd, unsigned long arg) { - int ret; + void __user *up = compat_ptr(arg); + struct rkmodule_inf *inf; + struct rkmodule_hdr_cfg *hdr; + struct preisp_hdrae_exp_s *hdrae; + long ret; + u32 stream = 0; - ret = regulator_disable(ov7251->core_regulator); - if (ret < 0) - dev_err(ov7251->dev, "core regulator disable failed\n"); + switch (cmd) { + case RKMODULE_GET_MODULE_INFO: + inf = kzalloc(sizeof(*inf), GFP_KERNEL); + if (!inf) { + ret = -ENOMEM; + return ret; + } - ret = regulator_disable(ov7251->analog_regulator); - if (ret < 0) - dev_err(ov7251->dev, "analog regulator disable failed\n"); + ret = ov7251_ioctl(sd, cmd, inf); + if (!ret) { + if (copy_to_user(up, inf, sizeof(*inf))) + ret = -EFAULT; + } + kfree(inf); + break; + case RKMODULE_GET_HDR_CFG: + hdr = kzalloc(sizeof(*hdr), GFP_KERNEL); + if (!hdr) { + ret = -ENOMEM; + return ret; + } - ret = regulator_disable(ov7251->io_regulator); - if (ret < 0) - dev_err(ov7251->dev, "io regulator disable failed\n"); -} + ret = ov7251_ioctl(sd, cmd, hdr); + if (!ret) { + if (copy_to_user(up, hdr, sizeof(*hdr))) + ret = -EFAULT; + } + kfree(hdr); + break; + case RKMODULE_SET_HDR_CFG: + hdr = kzalloc(sizeof(*hdr), GFP_KERNEL); + if (!hdr) { + ret = -ENOMEM; + return ret; + } -static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val) -{ - u8 regbuf[3]; - int ret; + ret = copy_from_user(hdr, up, sizeof(*hdr)); + if (!ret) + ret = ov7251_ioctl(sd, cmd, hdr); + else + ret = -EFAULT; + kfree(hdr); + break; + case PREISP_CMD_SET_HDRAE_EXP: + hdrae = kzalloc(sizeof(*hdrae), GFP_KERNEL); + if (!hdrae) { + ret = -ENOMEM; + return ret; + } - regbuf[0] = reg >> 8; - regbuf[1] = reg & 0xff; - regbuf[2] = val; - - ret = i2c_master_send(ov7251->i2c_client, regbuf, 3); - if (ret < 0) { - dev_err(ov7251->dev, "%s: write reg error %d: reg=%x, val=%x\n", - __func__, ret, reg, val); - return ret; + ret = copy_from_user(hdrae, up, sizeof(*hdrae)); + if (!ret) + ret = ov7251_ioctl(sd, cmd, hdrae); + else + ret = -EFAULT; + kfree(hdrae); + break; + case RKMODULE_SET_QUICK_STREAM: + ret = copy_from_user(&stream, up, sizeof(u32)); + if (!ret) + ret = ov7251_ioctl(sd, cmd, &stream); + else + ret = -EFAULT; + break; + default: + ret = -ENOIOCTLCMD; + break; } - return 0; + return ret; +} +#endif + +static int __ov7251_start_stream(struct ov7251 *ov7251) +{ + int ret; + + ret = ov7251_write_array(ov7251->client, ov7251->cur_mode->reg_list); + if (ret) + return ret; + + /* In case these controls are set before streaming */ + ret = __v4l2_ctrl_handler_setup(&ov7251->ctrl_handler); + if (ret) + return ret; + + return ov7251_write_reg(ov7251->client, OV7251_REG_CTRL_MODE, + OV7251_REG_VALUE_08BIT, OV7251_MODE_STREAMING); } -static int ov7251_write_seq_regs(struct ov7251 *ov7251, u16 reg, u8 *val, - u8 num) +static int __ov7251_stop_stream(struct ov7251 *ov7251) { - u8 regbuf[5]; - u8 nregbuf = sizeof(reg) + num * sizeof(*val); + return ov7251_write_reg(ov7251->client, OV7251_REG_CTRL_MODE, + OV7251_REG_VALUE_08BIT, OV7251_MODE_SW_STANDBY); +} + +static int ov7251_s_stream(struct v4l2_subdev *sd, int on) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + struct i2c_client *client = ov7251->client; int ret = 0; - if (nregbuf > sizeof(regbuf)) - return -EINVAL; + mutex_lock(&ov7251->mutex); + on = !!on; + if (on == ov7251->streaming) + goto unlock_and_return; - regbuf[0] = reg >> 8; - regbuf[1] = reg & 0xff; + if (on) { + ret = pm_runtime_get_sync(&client->dev); + if (ret < 0) { + pm_runtime_put_noidle(&client->dev); + goto unlock_and_return; + } - memcpy(regbuf + 2, val, num); - - ret = i2c_master_send(ov7251->i2c_client, regbuf, nregbuf); - if (ret < 0) { - dev_err(ov7251->dev, - "%s: write seq regs error %d: first reg=%x\n", - __func__, ret, reg); - return ret; + ret = __ov7251_start_stream(ov7251); + if (ret) { + v4l2_err(sd, "start stream failed while write regs\n"); + pm_runtime_put(&client->dev); + goto unlock_and_return; + } + usleep_range(10 * 1000, 12 * 1000); + } else { + __ov7251_stop_stream(ov7251); + pm_runtime_put(&client->dev); } - return 0; -} + ov7251->streaming = on; -static int ov7251_read_reg(struct ov7251 *ov7251, u16 reg, u8 *val) -{ - u8 regbuf[2]; - int ret; +unlock_and_return: + mutex_unlock(&ov7251->mutex); - regbuf[0] = reg >> 8; - regbuf[1] = reg & 0xff; - - ret = i2c_master_send(ov7251->i2c_client, regbuf, 2); - if (ret < 0) { - dev_err(ov7251->dev, "%s: write reg error %d: reg=%x\n", - __func__, ret, reg); - return ret; - } - - ret = i2c_master_recv(ov7251->i2c_client, val, 1); - if (ret < 0) { - dev_err(ov7251->dev, "%s: read reg error %d: reg=%x\n", - __func__, ret, reg); - return ret; - } - - return 0; -} - -static int ov7251_set_exposure(struct ov7251 *ov7251, s32 exposure) -{ - u16 reg; - u8 val[3]; - - reg = OV7251_AEC_EXPO_0; - val[0] = (exposure & 0xf000) >> 12; /* goes to OV7251_AEC_EXPO_0 */ - val[1] = (exposure & 0x0ff0) >> 4; /* goes to OV7251_AEC_EXPO_1 */ - val[2] = (exposure & 0x000f) << 4; /* goes to OV7251_AEC_EXPO_2 */ - - return ov7251_write_seq_regs(ov7251, reg, val, 3); -} - -static int ov7251_set_gain(struct ov7251 *ov7251, s32 gain) -{ - u16 reg; - u8 val[2]; - - reg = OV7251_AEC_AGC_ADJ_0; - val[0] = (gain & 0x0300) >> 8; /* goes to OV7251_AEC_AGC_ADJ_0 */ - val[1] = gain & 0xff; /* goes to OV7251_AEC_AGC_ADJ_1 */ - - return ov7251_write_seq_regs(ov7251, reg, val, 2); -} - -static int ov7251_set_register_array(struct ov7251 *ov7251, - const struct reg_value *settings, - unsigned int num_settings) -{ - unsigned int i; - int ret; - - for (i = 0; i < num_settings; ++i, ++settings) { - ret = ov7251_write_reg(ov7251, settings->reg, settings->val); - if (ret < 0) - return ret; - } - - return 0; -} - -static int ov7251_set_power_on(struct ov7251 *ov7251) -{ - int ret; - u32 wait_us; - - ret = ov7251_regulators_enable(ov7251); - if (ret < 0) - return ret; - - ret = clk_prepare_enable(ov7251->xclk); - if (ret < 0) { - dev_err(ov7251->dev, "clk prepare enable failed\n"); - ov7251_regulators_disable(ov7251); - return ret; - } - - gpiod_set_value_cansleep(ov7251->enable_gpio, 1); - - /* wait at least 65536 external clock cycles */ - wait_us = DIV_ROUND_UP(65536 * 1000, - DIV_ROUND_UP(ov7251->xclk_freq, 1000)); - usleep_range(wait_us, wait_us + 1000); - - return 0; -} - -static void ov7251_set_power_off(struct ov7251 *ov7251) -{ - clk_disable_unprepare(ov7251->xclk); - gpiod_set_value_cansleep(ov7251->enable_gpio, 0); - ov7251_regulators_disable(ov7251); + return ret; } static int ov7251_s_power(struct v4l2_subdev *sd, int on) { struct ov7251 *ov7251 = to_ov7251(sd); + struct i2c_client *client = ov7251->client; int ret = 0; - mutex_lock(&ov7251->lock); + mutex_lock(&ov7251->mutex); /* If the power state is not modified - no work to do. */ if (ov7251->power_on == !!on) - goto exit; + goto unlock_and_return; if (on) { - ret = ov7251_set_power_on(ov7251); - if (ret < 0) - goto exit; - - ret = ov7251_set_register_array(ov7251, - ov7251_global_init_setting, - ARRAY_SIZE(ov7251_global_init_setting)); + ret = pm_runtime_get_sync(&client->dev); if (ret < 0) { - dev_err(ov7251->dev, "could not set init registers\n"); - ov7251_set_power_off(ov7251); - goto exit; + pm_runtime_put_noidle(&client->dev); + goto unlock_and_return; + } + + ret = ov7251_write_array(ov7251->client, ov7251_global_regs); + if (ret) { + v4l2_err(sd, "could not set init registers\n"); + pm_runtime_put_noidle(&client->dev); + goto unlock_and_return; } ov7251->power_on = true; } else { - ov7251_set_power_off(ov7251); + pm_runtime_put(&client->dev); ov7251->power_on = false; } -exit: - mutex_unlock(&ov7251->lock); +unlock_and_return: + mutex_unlock(&ov7251->mutex); return ret; } -static int ov7251_set_hflip(struct ov7251 *ov7251, s32 value) +/* Calculate the delay in us by clock rate and clock cycles */ +static inline u32 ov7251_cal_delay(u32 cycles) { - u8 val = ov7251->timing_format2; - int ret; - - if (value) - val |= OV7251_TIMING_FORMAT2_MIRROR; - else - val &= ~OV7251_TIMING_FORMAT2_MIRROR; - - ret = ov7251_write_reg(ov7251, OV7251_TIMING_FORMAT2, val); - if (!ret) - ov7251->timing_format2 = val; - - return ret; + return DIV_ROUND_UP(cycles, OV7251_XVCLK_FREQ / 1000 / 1000); } -static int ov7251_set_vflip(struct ov7251 *ov7251, s32 value) +static int __ov7251_power_on(struct ov7251 *ov7251) { - u8 val = ov7251->timing_format1; int ret; + u32 delay_us; + struct device *dev = &ov7251->client->dev; - if (value) - val |= OV7251_TIMING_FORMAT1_VFLIP; + if (!IS_ERR_OR_NULL(ov7251->pins_default)) { + ret = pinctrl_select_state(ov7251->pinctrl, + ov7251->pins_default); + if (ret < 0) + dev_err(dev, "could not set pins\n"); + } + ret = clk_set_rate(ov7251->xvclk, OV7251_XVCLK_FREQ); + if (ret < 0) + dev_warn(dev, "Failed to set xvclk rate (24MHz)\n"); + if (clk_get_rate(ov7251->xvclk) != OV7251_XVCLK_FREQ) + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); + ret = clk_prepare_enable(ov7251->xvclk); + if (ret < 0) { + dev_err(dev, "Failed to enable xvclk\n"); + return ret; + } + + if (!IS_ERR(ov7251->reset_gpio)) + gpiod_set_value_cansleep(ov7251->reset_gpio, 0); + + ret = regulator_bulk_enable(OV7251_NUM_SUPPLIES, ov7251->supplies); + if (ret < 0) { + dev_err(dev, "Failed to enable regulators\n"); + goto disable_clk; + } + + usleep_range(5 * 1000, 10 * 1000); + if (!IS_ERR(ov7251->reset_gpio)) + gpiod_set_value_cansleep(ov7251->reset_gpio, 1); + + usleep_range(500, 1000); + if (!IS_ERR(ov7251->pwdn_gpio)) + gpiod_set_value_cansleep(ov7251->pwdn_gpio, 1); + + if (!IS_ERR(ov7251->reset_gpio)) + usleep_range(6000, 8000); else - val &= ~OV7251_TIMING_FORMAT1_VFLIP; + usleep_range(12000, 16000); - ret = ov7251_write_reg(ov7251, OV7251_TIMING_FORMAT1, val); - if (!ret) - ov7251->timing_format1 = val; + /* 8192 cycles prior to first SCCB transaction */ + delay_us = ov7251_cal_delay(8192); + usleep_range(delay_us, delay_us * 2); + + return 0; + +disable_clk: + clk_disable_unprepare(ov7251->xvclk); return ret; } -static int ov7251_set_test_pattern(struct ov7251 *ov7251, s32 value) +static void __ov7251_power_off(struct ov7251 *ov7251) { - u8 val = ov7251->pre_isp_00; int ret; + struct device *dev = &ov7251->client->dev; - if (value) - val |= OV7251_PRE_ISP_00_TEST_PATTERN; - else - val &= ~OV7251_PRE_ISP_00_TEST_PATTERN; - - ret = ov7251_write_reg(ov7251, OV7251_PRE_ISP_00, val); - if (!ret) - ov7251->pre_isp_00 = val; - - return ret; + if (!IS_ERR(ov7251->pwdn_gpio)) + gpiod_set_value_cansleep(ov7251->pwdn_gpio, 0); + clk_disable_unprepare(ov7251->xvclk); + if (!IS_ERR(ov7251->reset_gpio)) + gpiod_set_value_cansleep(ov7251->reset_gpio, 0); + if (!IS_ERR_OR_NULL(ov7251->pins_sleep)) { + ret = pinctrl_select_state(ov7251->pinctrl, + ov7251->pins_sleep); + if (ret < 0) + dev_dbg(dev, "could not set pins\n"); + } + regulator_bulk_disable(OV7251_NUM_SUPPLIES, ov7251->supplies); } -static const char * const ov7251_test_pattern_menu[] = { - "Disabled", - "Vertical Pattern Bars", +static int ov7251_runtime_resume(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct ov7251 *ov7251 = to_ov7251(sd); + + return __ov7251_power_on(ov7251); +} + +static int ov7251_runtime_suspend(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct ov7251 *ov7251 = to_ov7251(sd); + + __ov7251_power_off(ov7251); + + return 0; +} + +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API +static int ov7251_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) +{ + struct ov7251 *ov7251 = to_ov7251(sd); + struct v4l2_mbus_framefmt *try_fmt = + v4l2_subdev_get_try_format(sd, fh->pad, 0); + const struct ov7251_mode *def_mode = &supported_modes[0]; + + mutex_lock(&ov7251->mutex); + /* Initialize try_fmt */ + try_fmt->width = def_mode->width; + try_fmt->height = def_mode->height; + try_fmt->code = def_mode->bus_fmt; + try_fmt->field = V4L2_FIELD_NONE; + + mutex_unlock(&ov7251->mutex); + /* No crop or compose */ + + return 0; +} +#endif + +static int ov7251_enum_frame_interval(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_frame_interval_enum *fie) +{ + if (fie->index >= ARRAY_SIZE(supported_modes)) + return -EINVAL; + + fie->code = supported_modes[fie->index].bus_fmt; + fie->width = supported_modes[fie->index].width; + fie->height = supported_modes[fie->index].height; + fie->interval = supported_modes[fie->index].max_fps; + fie->reserved[0] = supported_modes[fie->index].hdr_mode; + return 0; +} + +static const struct dev_pm_ops ov7251_pm_ops = { + SET_RUNTIME_PM_OPS(ov7251_runtime_suspend, + ov7251_runtime_resume, NULL) }; -static int ov7251_s_ctrl(struct v4l2_ctrl *ctrl) +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API +static const struct v4l2_subdev_internal_ops ov7251_internal_ops = { + .open = ov7251_open, +}; +#endif + +static const struct v4l2_subdev_core_ops ov7251_core_ops = { + .s_power = ov7251_s_power, + .ioctl = ov7251_ioctl, +#ifdef CONFIG_COMPAT + .compat_ioctl32 = ov7251_compat_ioctl32, +#endif +}; + +static const struct v4l2_subdev_video_ops ov7251_video_ops = { + .s_stream = ov7251_s_stream, + .g_frame_interval = ov7251_g_frame_interval, +}; + +static const struct v4l2_subdev_pad_ops ov7251_pad_ops = { + .enum_mbus_code = ov7251_enum_mbus_code, + .enum_frame_size = ov7251_enum_frame_sizes, + .enum_frame_interval = ov7251_enum_frame_interval, + .get_fmt = ov7251_get_fmt, + .set_fmt = ov7251_set_fmt, + .get_mbus_config = ov7251_g_mbus_config, +}; + +static const struct v4l2_subdev_ops ov7251_subdev_ops = { + .core = &ov7251_core_ops, + .video = &ov7251_video_ops, + .pad = &ov7251_pad_ops, +}; + +static int ov7251_set_ctrl(struct v4l2_ctrl *ctrl) { struct ov7251 *ov7251 = container_of(ctrl->handler, - struct ov7251, ctrls); - int ret; + struct ov7251, ctrl_handler); + struct i2c_client *client = ov7251->client; + s64 max; + int ret = 0; + u32 val = 0; - /* v4l2_ctrl_lock() locks our mutex */ + /* Propagate change of current control to all related controls */ + switch (ctrl->id) { + case V4L2_CID_VBLANK: + /* Update max exposure while meeting expected vblanking */ + max = ov7251->cur_mode->height + ctrl->val - 20; + __v4l2_ctrl_modify_range(ov7251->exposure, + ov7251->exposure->minimum, max, + ov7251->exposure->step, + ov7251->exposure->default_value); + break; + } - if (!ov7251->power_on) + if (!pm_runtime_get_if_in_use(&client->dev)) return 0; switch (ctrl->id) { case V4L2_CID_EXPOSURE: - ret = ov7251_set_exposure(ov7251, ctrl->val); + /* 4 least significant bits of expsoure are fractional part */ + ret = ov7251_write_reg(ov7251->client, OV7251_REG_EXPOSURE, + OV7251_REG_VALUE_24BIT, ctrl->val << 4); break; - case V4L2_CID_GAIN: - ret = ov7251_set_gain(ov7251, ctrl->val); + case V4L2_CID_ANALOGUE_GAIN: + ret = ov7251_write_reg(ov7251->client, OV7251_REG_ANALOG_GAIN, + OV7251_REG_VALUE_16BIT, + ctrl->val & ANALOG_GAIN_MASK); + break; + case V4L2_CID_VBLANK: + ret = ov7251_write_reg(ov7251->client, OV7251_REG_VTS, + OV7251_REG_VALUE_16BIT, + ctrl->val + ov7251->cur_mode->height); break; case V4L2_CID_TEST_PATTERN: - ret = ov7251_set_test_pattern(ov7251, ctrl->val); + ret = ov7251_enable_test_pattern(ov7251, ctrl->val); break; case V4L2_CID_HFLIP: - ret = ov7251_set_hflip(ov7251, ctrl->val); + ret = ov7251_read_reg(ov7251->client, OV7251_MIRROR_REG, + OV7251_REG_VALUE_08BIT, &val); + ret |= ov7251_write_reg(ov7251->client, OV7251_MIRROR_REG, + OV7251_REG_VALUE_08BIT, + OV7251_FETCH_MIRROR(val, ctrl->val)); break; case V4L2_CID_VFLIP: - ret = ov7251_set_vflip(ov7251, ctrl->val); + ret = ov7251_read_reg(ov7251->client, OV7251_FLIP_REG, + OV7251_REG_VALUE_08BIT, &val); + ret |= ov7251_write_reg(ov7251->client, OV7251_FLIP_REG, + OV7251_REG_VALUE_08BIT, + OV7251_FETCH_FLIP(val, ctrl->val)); break; + default: - ret = -EINVAL; + dev_warn(&client->dev, "%s Unhandled id:0x%x, val:0x%x\n", + __func__, ctrl->id, ctrl->val); break; } + pm_runtime_put(&client->dev); + return ret; } static const struct v4l2_ctrl_ops ov7251_ctrl_ops = { - .s_ctrl = ov7251_s_ctrl, + .s_ctrl = ov7251_set_ctrl, }; -static int ov7251_enum_mbus_code(struct v4l2_subdev *sd, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_mbus_code_enum *code) +static int ov7251_initialize_controls(struct ov7251 *ov7251) { - if (code->index > 0) - return -EINVAL; + const struct ov7251_mode *mode; + struct v4l2_ctrl_handler *handler; + struct v4l2_ctrl *ctrl; + s64 exposure_max, vblank_def; + u32 h_blank; + int ret; - code->code = MEDIA_BUS_FMT_Y10_1X10; + handler = &ov7251->ctrl_handler; + mode = ov7251->cur_mode; + ret = v4l2_ctrl_handler_init(handler, 9); + if (ret) + return ret; + handler->lock = &ov7251->mutex; + + ctrl = v4l2_ctrl_new_int_menu(handler, NULL, V4L2_CID_LINK_FREQ, + 0, 0, link_freq_menu_items); + if (ctrl) + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY; + + v4l2_ctrl_new_std(handler, NULL, V4L2_CID_PIXEL_RATE, + 0, PIXEL_RATE_WITH_240M_10BIT, 1, PIXEL_RATE_WITH_240M_10BIT); + + h_blank = mode->hts_def - mode->width; + ov7251->hblank = v4l2_ctrl_new_std(handler, NULL, V4L2_CID_HBLANK, + h_blank, h_blank, 1, h_blank); + if (ov7251->hblank) + ov7251->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY; + vblank_def = mode->vts_def - mode->height; + ov7251->vblank = v4l2_ctrl_new_std(handler, &ov7251_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV7251_VTS_MAX - mode->height, + 1, vblank_def); + ov7251->cur_fps = mode->max_fps; + exposure_max = mode->vts_def - 20; + ov7251->exposure = v4l2_ctrl_new_std(handler, &ov7251_ctrl_ops, + V4L2_CID_EXPOSURE, OV7251_EXPOSURE_MIN, + exposure_max, OV7251_EXPOSURE_STEP, + mode->exp_def); + ov7251->anal_gain = v4l2_ctrl_new_std(handler, &ov7251_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, ANALOG_GAIN_MIN, + ANALOG_GAIN_MAX, ANALOG_GAIN_STEP, + ANALOG_GAIN_DEFAULT); + + ov7251->test_pattern = v4l2_ctrl_new_std_menu_items(handler, + &ov7251_ctrl_ops, + V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov7251_test_pattern_menu) - 1, + 0, 0, ov7251_test_pattern_menu); + v4l2_ctrl_new_std(handler, &ov7251_ctrl_ops, + V4L2_CID_HFLIP, 0, 1, 1, 0); + v4l2_ctrl_new_std(handler, &ov7251_ctrl_ops, + V4L2_CID_VFLIP, 0, 1, 1, 0); + if (handler->error) { + ret = handler->error; + dev_err(&ov7251->client->dev, + "Failed to init controls(%d)\n", ret); + goto err_free_handler; + } + + ov7251->subdev.ctrl_handler = handler; + + return 0; + +err_free_handler: + v4l2_ctrl_handler_free(handler); + + return ret; +} + +static int ov7251_check_sensor_id(struct ov7251 *ov7251, + struct i2c_client *client) +{ + struct device *dev = &ov7251->client->dev; + u32 id = 0; + int ret; + + ret = ov7251_read_reg(client, OV7251_REG_CHIP_ID, + OV7251_REG_VALUE_08BIT, &id); + if (id != CHIP_ID) { + dev_err(dev, "Unexpected sensor id(%06x), ret(%d)\n", id, ret); + return -ENODEV; + } + + dev_info(dev, "Detected OV%06x sensor\n", CHIP_ID); return 0; } -static int ov7251_enum_frame_size(struct v4l2_subdev *subdev, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_size_enum *fse) +static int ov7251_configure_regulators(struct ov7251 *ov7251) { - if (fse->code != MEDIA_BUS_FMT_Y10_1X10) - return -EINVAL; - - if (fse->index >= ARRAY_SIZE(ov7251_mode_info_data)) - return -EINVAL; - - fse->min_width = ov7251_mode_info_data[fse->index].width; - fse->max_width = ov7251_mode_info_data[fse->index].width; - fse->min_height = ov7251_mode_info_data[fse->index].height; - fse->max_height = ov7251_mode_info_data[fse->index].height; - - return 0; -} - -static int ov7251_enum_frame_ival(struct v4l2_subdev *subdev, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_frame_interval_enum *fie) -{ - unsigned int index = fie->index; unsigned int i; - for (i = 0; i < ARRAY_SIZE(ov7251_mode_info_data); i++) { - if (fie->width != ov7251_mode_info_data[i].width || - fie->height != ov7251_mode_info_data[i].height) - continue; + for (i = 0; i < OV7251_NUM_SUPPLIES; i++) + ov7251->supplies[i].supply = ov7251_supply_names[i]; - if (index-- == 0) { - fie->interval = ov7251_mode_info_data[i].timeperframe; - return 0; - } - } - - return -EINVAL; + return devm_regulator_bulk_get(&ov7251->client->dev, + OV7251_NUM_SUPPLIES, + ov7251->supplies); } -static struct v4l2_mbus_framefmt * -__ov7251_get_pad_format(struct ov7251 *ov7251, - struct v4l2_subdev_pad_config *cfg, - unsigned int pad, - enum v4l2_subdev_format_whence which) -{ - switch (which) { - case V4L2_SUBDEV_FORMAT_TRY: - return v4l2_subdev_get_try_format(&ov7251->sd, cfg, pad); - case V4L2_SUBDEV_FORMAT_ACTIVE: - return &ov7251->fmt; - default: - return NULL; - } -} - -static int ov7251_get_format(struct v4l2_subdev *sd, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_format *format) -{ - struct ov7251 *ov7251 = to_ov7251(sd); - - mutex_lock(&ov7251->lock); - format->format = *__ov7251_get_pad_format(ov7251, cfg, format->pad, - format->which); - mutex_unlock(&ov7251->lock); - - return 0; -} - -static struct v4l2_rect * -__ov7251_get_pad_crop(struct ov7251 *ov7251, struct v4l2_subdev_pad_config *cfg, - unsigned int pad, enum v4l2_subdev_format_whence which) -{ - switch (which) { - case V4L2_SUBDEV_FORMAT_TRY: - return v4l2_subdev_get_try_crop(&ov7251->sd, cfg, pad); - case V4L2_SUBDEV_FORMAT_ACTIVE: - return &ov7251->crop; - default: - return NULL; - } -} - -static inline u32 avg_fps(const struct v4l2_fract *t) -{ - return (t->denominator + (t->numerator >> 1)) / t->numerator; -} - -static const struct ov7251_mode_info * -ov7251_find_mode_by_ival(struct ov7251 *ov7251, struct v4l2_fract *timeperframe) -{ - const struct ov7251_mode_info *mode = ov7251->current_mode; - unsigned int fps_req = avg_fps(timeperframe); - unsigned int max_dist_match = (unsigned int) -1; - unsigned int i, n = 0; - - for (i = 0; i < ARRAY_SIZE(ov7251_mode_info_data); i++) { - unsigned int dist; - unsigned int fps_tmp; - - if (mode->width != ov7251_mode_info_data[i].width || - mode->height != ov7251_mode_info_data[i].height) - continue; - - fps_tmp = avg_fps(&ov7251_mode_info_data[i].timeperframe); - - dist = abs(fps_req - fps_tmp); - - if (dist < max_dist_match) { - n = i; - max_dist_match = dist; - } - } - - return &ov7251_mode_info_data[n]; -} - -static int ov7251_set_format(struct v4l2_subdev *sd, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_format *format) -{ - struct ov7251 *ov7251 = to_ov7251(sd); - struct v4l2_mbus_framefmt *__format; - struct v4l2_rect *__crop; - const struct ov7251_mode_info *new_mode; - int ret = 0; - - mutex_lock(&ov7251->lock); - - __crop = __ov7251_get_pad_crop(ov7251, cfg, format->pad, format->which); - - new_mode = v4l2_find_nearest_size(ov7251_mode_info_data, - ARRAY_SIZE(ov7251_mode_info_data), - width, height, - format->format.width, format->format.height); - - __crop->width = new_mode->width; - __crop->height = new_mode->height; - - if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) { - ret = __v4l2_ctrl_s_ctrl_int64(ov7251->pixel_clock, - new_mode->pixel_clock); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->link_freq, - new_mode->link_freq); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_modify_range(ov7251->exposure, - 1, new_mode->exposure_max, - 1, new_mode->exposure_def); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->exposure, - new_mode->exposure_def); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16); - if (ret < 0) - goto exit; - - ov7251->current_mode = new_mode; - } - - __format = __ov7251_get_pad_format(ov7251, cfg, format->pad, - format->which); - __format->width = __crop->width; - __format->height = __crop->height; - __format->code = MEDIA_BUS_FMT_Y10_1X10; - __format->field = V4L2_FIELD_NONE; - __format->colorspace = V4L2_COLORSPACE_SRGB; - __format->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(__format->colorspace); - __format->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true, - __format->colorspace, __format->ycbcr_enc); - __format->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(__format->colorspace); - - format->format = *__format; - -exit: - mutex_unlock(&ov7251->lock); - - return ret; -} - -static int ov7251_entity_init_cfg(struct v4l2_subdev *subdev, - struct v4l2_subdev_pad_config *cfg) -{ - struct v4l2_subdev_format fmt = { - .which = cfg ? V4L2_SUBDEV_FORMAT_TRY - : V4L2_SUBDEV_FORMAT_ACTIVE, - .format = { - .width = 640, - .height = 480 - } - }; - - ov7251_set_format(subdev, cfg, &fmt); - - return 0; -} - -static int ov7251_get_selection(struct v4l2_subdev *sd, - struct v4l2_subdev_pad_config *cfg, - struct v4l2_subdev_selection *sel) -{ - struct ov7251 *ov7251 = to_ov7251(sd); - - if (sel->target != V4L2_SEL_TGT_CROP) - return -EINVAL; - - mutex_lock(&ov7251->lock); - sel->r = *__ov7251_get_pad_crop(ov7251, cfg, sel->pad, - sel->which); - mutex_unlock(&ov7251->lock); - - return 0; -} - -static int ov7251_s_stream(struct v4l2_subdev *subdev, int enable) -{ - struct ov7251 *ov7251 = to_ov7251(subdev); - int ret; - - mutex_lock(&ov7251->lock); - - if (enable) { - ret = ov7251_set_register_array(ov7251, - ov7251->current_mode->data, - ov7251->current_mode->data_size); - if (ret < 0) { - dev_err(ov7251->dev, "could not set mode %dx%d\n", - ov7251->current_mode->width, - ov7251->current_mode->height); - goto exit; - } - ret = __v4l2_ctrl_handler_setup(&ov7251->ctrls); - if (ret < 0) { - dev_err(ov7251->dev, "could not sync v4l2 controls\n"); - goto exit; - } - ret = ov7251_write_reg(ov7251, OV7251_SC_MODE_SELECT, - OV7251_SC_MODE_SELECT_STREAMING); - } else { - ret = ov7251_write_reg(ov7251, OV7251_SC_MODE_SELECT, - OV7251_SC_MODE_SELECT_SW_STANDBY); - } - -exit: - mutex_unlock(&ov7251->lock); - - return ret; -} - -static int ov7251_get_frame_interval(struct v4l2_subdev *subdev, - struct v4l2_subdev_frame_interval *fi) -{ - struct ov7251 *ov7251 = to_ov7251(subdev); - - mutex_lock(&ov7251->lock); - fi->interval = ov7251->current_mode->timeperframe; - mutex_unlock(&ov7251->lock); - - return 0; -} - -static int ov7251_set_frame_interval(struct v4l2_subdev *subdev, - struct v4l2_subdev_frame_interval *fi) -{ - struct ov7251 *ov7251 = to_ov7251(subdev); - const struct ov7251_mode_info *new_mode; - int ret = 0; - - mutex_lock(&ov7251->lock); - new_mode = ov7251_find_mode_by_ival(ov7251, &fi->interval); - - if (new_mode != ov7251->current_mode) { - ret = __v4l2_ctrl_s_ctrl_int64(ov7251->pixel_clock, - new_mode->pixel_clock); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->link_freq, - new_mode->link_freq); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_modify_range(ov7251->exposure, - 1, new_mode->exposure_max, - 1, new_mode->exposure_def); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->exposure, - new_mode->exposure_def); - if (ret < 0) - goto exit; - - ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16); - if (ret < 0) - goto exit; - - ov7251->current_mode = new_mode; - } - - fi->interval = ov7251->current_mode->timeperframe; - -exit: - mutex_unlock(&ov7251->lock); - - return ret; -} - -static const struct v4l2_subdev_core_ops ov7251_core_ops = { - .s_power = ov7251_s_power, -}; - -static const struct v4l2_subdev_video_ops ov7251_video_ops = { - .s_stream = ov7251_s_stream, - .g_frame_interval = ov7251_get_frame_interval, - .s_frame_interval = ov7251_set_frame_interval, -}; - -static const struct v4l2_subdev_pad_ops ov7251_subdev_pad_ops = { - .init_cfg = ov7251_entity_init_cfg, - .enum_mbus_code = ov7251_enum_mbus_code, - .enum_frame_size = ov7251_enum_frame_size, - .enum_frame_interval = ov7251_enum_frame_ival, - .get_fmt = ov7251_get_format, - .set_fmt = ov7251_set_format, - .get_selection = ov7251_get_selection, -}; - -static const struct v4l2_subdev_ops ov7251_subdev_ops = { - .core = &ov7251_core_ops, - .video = &ov7251_video_ops, - .pad = &ov7251_subdev_pad_ops, -}; - -static int ov7251_probe(struct i2c_client *client) +static int ov7251_probe(struct i2c_client *client, + const struct i2c_device_id *id) { struct device *dev = &client->dev; - struct fwnode_handle *endpoint; + struct device_node *node = dev->of_node; struct ov7251 *ov7251; - u8 chip_id_high, chip_id_low, chip_rev; + struct v4l2_subdev *sd; + char facing[2]; int ret; - ov7251 = devm_kzalloc(dev, sizeof(struct ov7251), GFP_KERNEL); + dev_info(dev, "driver version: %02x.%02x.%02x", + DRIVER_VERSION >> 16, + (DRIVER_VERSION & 0xff00) >> 8, + DRIVER_VERSION & 0x00ff); + + ov7251 = devm_kzalloc(dev, sizeof(*ov7251), GFP_KERNEL); if (!ov7251) return -ENOMEM; - ov7251->i2c_client = client; - ov7251->dev = dev; - - endpoint = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL); - if (!endpoint) { - dev_err(dev, "endpoint node not found\n"); - return -EINVAL; - } - - ret = v4l2_fwnode_endpoint_parse(endpoint, &ov7251->ep); - fwnode_handle_put(endpoint); - if (ret < 0) { - dev_err(dev, "parsing endpoint node failed\n"); - return ret; - } - - if (ov7251->ep.bus_type != V4L2_MBUS_CSI2_DPHY) { - dev_err(dev, "invalid bus type (%u), must be CSI2 (%u)\n", - ov7251->ep.bus_type, V4L2_MBUS_CSI2_DPHY); - return -EINVAL; - } - - /* get system clock (xclk) */ - ov7251->xclk = devm_clk_get(dev, "xclk"); - if (IS_ERR(ov7251->xclk)) { - dev_err(dev, "could not get xclk"); - return PTR_ERR(ov7251->xclk); - } - - ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", - &ov7251->xclk_freq); + ret = of_property_read_u32(node, RKMODULE_CAMERA_MODULE_INDEX, + &ov7251->module_index); + ret |= of_property_read_string(node, RKMODULE_CAMERA_MODULE_FACING, + &ov7251->module_facing); + ret |= of_property_read_string(node, RKMODULE_CAMERA_MODULE_NAME, + &ov7251->module_name); + ret |= of_property_read_string(node, RKMODULE_CAMERA_LENS_NAME, + &ov7251->len_name); if (ret) { - dev_err(dev, "could not get xclk frequency\n"); - return ret; - } - - /* external clock must be 24MHz, allow 1% tolerance */ - if (ov7251->xclk_freq < 23760000 || ov7251->xclk_freq > 24240000) { - dev_err(dev, "external clock frequency %u is not supported\n", - ov7251->xclk_freq); + dev_err(dev, "could not get module information!\n"); return -EINVAL; } - ret = clk_set_rate(ov7251->xclk, ov7251->xclk_freq); + ov7251->client = client; + ov7251->cur_mode = &supported_modes[0]; + + ov7251->xvclk = devm_clk_get(dev, "xvclk"); + if (IS_ERR(ov7251->xvclk)) { + dev_err(dev, "Failed to get xvclk\n"); + return -EINVAL; + } + + ov7251->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ov7251->reset_gpio)) + dev_warn(dev, "Failed to get reset-gpios\n"); + + ov7251->pwdn_gpio = devm_gpiod_get(dev, "pwdn", GPIOD_OUT_LOW); + if (IS_ERR(ov7251->pwdn_gpio)) + dev_warn(dev, "Failed to get pwdn-gpios\n"); + + ov7251->pinctrl = devm_pinctrl_get(dev); + if (!IS_ERR(ov7251->pinctrl)) { + ov7251->pins_default = + pinctrl_lookup_state(ov7251->pinctrl, + OF_CAMERA_PINCTRL_STATE_DEFAULT); + if (IS_ERR(ov7251->pins_default)) + dev_err(dev, "could not get default pinstate\n"); + + ov7251->pins_sleep = + pinctrl_lookup_state(ov7251->pinctrl, + OF_CAMERA_PINCTRL_STATE_SLEEP); + if (IS_ERR(ov7251->pins_sleep)) + dev_err(dev, "could not get sleep pinstate\n"); + } else { + dev_err(dev, "no pinctrl\n"); + } + + ret = ov7251_configure_regulators(ov7251); if (ret) { - dev_err(dev, "could not set xclk frequency\n"); + dev_err(dev, "Failed to get power regulators\n"); return ret; } - ov7251->io_regulator = devm_regulator_get(dev, "vdddo"); - if (IS_ERR(ov7251->io_regulator)) { - dev_err(dev, "cannot get io regulator\n"); - return PTR_ERR(ov7251->io_regulator); - } + mutex_init(&ov7251->mutex); - ov7251->core_regulator = devm_regulator_get(dev, "vddd"); - if (IS_ERR(ov7251->core_regulator)) { - dev_err(dev, "cannot get core regulator\n"); - return PTR_ERR(ov7251->core_regulator); - } + sd = &ov7251->subdev; + v4l2_i2c_subdev_init(sd, client, &ov7251_subdev_ops); + ret = ov7251_initialize_controls(ov7251); + if (ret) + goto err_destroy_mutex; - ov7251->analog_regulator = devm_regulator_get(dev, "vdda"); - if (IS_ERR(ov7251->analog_regulator)) { - dev_err(dev, "cannot get analog regulator\n"); - return PTR_ERR(ov7251->analog_regulator); - } + ret = __ov7251_power_on(ov7251); + if (ret) + goto err_free_handler; - ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); - if (IS_ERR(ov7251->enable_gpio)) { - dev_err(dev, "cannot get enable gpio\n"); - return PTR_ERR(ov7251->enable_gpio); - } + ret = ov7251_check_sensor_id(ov7251, client); + if (ret) + goto err_power_off; - mutex_init(&ov7251->lock); - - v4l2_ctrl_handler_init(&ov7251->ctrls, 7); - ov7251->ctrls.lock = &ov7251->lock; - - v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops, - V4L2_CID_HFLIP, 0, 1, 1, 0); - v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops, - V4L2_CID_VFLIP, 0, 1, 1, 0); - ov7251->exposure = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops, - V4L2_CID_EXPOSURE, 1, 32, 1, 32); - ov7251->gain = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops, - V4L2_CID_GAIN, 16, 1023, 1, 16); - v4l2_ctrl_new_std_menu_items(&ov7251->ctrls, &ov7251_ctrl_ops, - V4L2_CID_TEST_PATTERN, - ARRAY_SIZE(ov7251_test_pattern_menu) - 1, - 0, 0, ov7251_test_pattern_menu); - ov7251->pixel_clock = v4l2_ctrl_new_std(&ov7251->ctrls, - &ov7251_ctrl_ops, - V4L2_CID_PIXEL_RATE, - 1, INT_MAX, 1, 1); - ov7251->link_freq = v4l2_ctrl_new_int_menu(&ov7251->ctrls, - &ov7251_ctrl_ops, - V4L2_CID_LINK_FREQ, - ARRAY_SIZE(link_freq) - 1, - 0, link_freq); - if (ov7251->link_freq) - ov7251->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; - - ov7251->sd.ctrl_handler = &ov7251->ctrls; - - if (ov7251->ctrls.error) { - dev_err(dev, "%s: control initialization error %d\n", - __func__, ov7251->ctrls.error); - ret = ov7251->ctrls.error; - goto free_ctrl; - } - - v4l2_i2c_subdev_init(&ov7251->sd, client, &ov7251_subdev_ops); - ov7251->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API + sd->internal_ops = &ov7251_internal_ops; + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | + V4L2_SUBDEV_FL_HAS_EVENTS; +#endif +#if defined(CONFIG_MEDIA_CONTROLLER) ov7251->pad.flags = MEDIA_PAD_FL_SOURCE; - ov7251->sd.dev = &client->dev; - ov7251->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR; + sd->entity.function = MEDIA_ENT_F_CAM_SENSOR; + ret = media_entity_pads_init(&sd->entity, 1, &ov7251->pad); + if (ret < 0) + goto err_power_off; +#endif - ret = media_entity_pads_init(&ov7251->sd.entity, 1, &ov7251->pad); - if (ret < 0) { - dev_err(dev, "could not register media entity\n"); - goto free_ctrl; + memset(facing, 0, sizeof(facing)); + if (strcmp(ov7251->module_facing, "back") == 0) + facing[0] = 'b'; + else + facing[0] = 'f'; + + snprintf(sd->name, sizeof(sd->name), "m%02d_%s_%s %s", + ov7251->module_index, facing, + OV7251_NAME, dev_name(sd->dev)); + ret = v4l2_async_register_subdev_sensor_common(sd); + if (ret) { + dev_err(dev, "v4l2 async register subdev failed\n"); + goto err_clean_entity; } - ret = ov7251_s_power(&ov7251->sd, true); - if (ret < 0) { - dev_err(dev, "could not power up OV7251\n"); - goto free_entity; - } - - ret = ov7251_read_reg(ov7251, OV7251_CHIP_ID_HIGH, &chip_id_high); - if (ret < 0 || chip_id_high != OV7251_CHIP_ID_HIGH_BYTE) { - dev_err(dev, "could not read ID high\n"); - ret = -ENODEV; - goto power_down; - } - ret = ov7251_read_reg(ov7251, OV7251_CHIP_ID_LOW, &chip_id_low); - if (ret < 0 || chip_id_low != OV7251_CHIP_ID_LOW_BYTE) { - dev_err(dev, "could not read ID low\n"); - ret = -ENODEV; - goto power_down; - } - - ret = ov7251_read_reg(ov7251, OV7251_SC_GP_IO_IN1, &chip_rev); - if (ret < 0) { - dev_err(dev, "could not read revision\n"); - ret = -ENODEV; - goto power_down; - } - chip_rev >>= 4; - - dev_info(dev, "OV7251 revision %x (%s) detected at address 0x%02x\n", - chip_rev, - chip_rev == 0x4 ? "1A / 1B" : - chip_rev == 0x5 ? "1C / 1D" : - chip_rev == 0x6 ? "1E" : - chip_rev == 0x7 ? "1F" : "unknown", - client->addr); - - ret = ov7251_read_reg(ov7251, OV7251_PRE_ISP_00, - &ov7251->pre_isp_00); - if (ret < 0) { - dev_err(dev, "could not read test pattern value\n"); - ret = -ENODEV; - goto power_down; - } - - ret = ov7251_read_reg(ov7251, OV7251_TIMING_FORMAT1, - &ov7251->timing_format1); - if (ret < 0) { - dev_err(dev, "could not read vflip value\n"); - ret = -ENODEV; - goto power_down; - } - - ret = ov7251_read_reg(ov7251, OV7251_TIMING_FORMAT2, - &ov7251->timing_format2); - if (ret < 0) { - dev_err(dev, "could not read hflip value\n"); - ret = -ENODEV; - goto power_down; - } - - ov7251_s_power(&ov7251->sd, false); - - ret = v4l2_async_register_subdev(&ov7251->sd); - if (ret < 0) { - dev_err(dev, "could not register v4l2 device\n"); - goto free_entity; - } - - ov7251_entity_init_cfg(&ov7251->sd, NULL); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + pm_runtime_idle(dev); return 0; -power_down: - ov7251_s_power(&ov7251->sd, false); -free_entity: - media_entity_cleanup(&ov7251->sd.entity); -free_ctrl: - v4l2_ctrl_handler_free(&ov7251->ctrls); - mutex_destroy(&ov7251->lock); +err_clean_entity: +#if defined(CONFIG_MEDIA_CONTROLLER) + media_entity_cleanup(&sd->entity); +#endif +err_power_off: + __ov7251_power_off(ov7251); +err_free_handler: + v4l2_ctrl_handler_free(&ov7251->ctrl_handler); +err_destroy_mutex: + mutex_destroy(&ov7251->mutex); return ret; } @@ -1473,31 +1754,57 @@ static int ov7251_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); struct ov7251 *ov7251 = to_ov7251(sd); - v4l2_async_unregister_subdev(&ov7251->sd); - media_entity_cleanup(&ov7251->sd.entity); - v4l2_ctrl_handler_free(&ov7251->ctrls); - mutex_destroy(&ov7251->lock); + v4l2_async_unregister_subdev(sd); +#if defined(CONFIG_MEDIA_CONTROLLER) + media_entity_cleanup(&sd->entity); +#endif + v4l2_ctrl_handler_free(&ov7251->ctrl_handler); + mutex_destroy(&ov7251->mutex); + + pm_runtime_disable(&client->dev); + if (!pm_runtime_status_suspended(&client->dev)) + __ov7251_power_off(ov7251); + pm_runtime_set_suspended(&client->dev); return 0; } +#if IS_ENABLED(CONFIG_OF) static const struct of_device_id ov7251_of_match[] = { { .compatible = "ovti,ov7251" }, - { /* sentinel */ } + {}, }; MODULE_DEVICE_TABLE(of, ov7251_of_match); +#endif + +static const struct i2c_device_id ov7251_match_id[] = { + { "ovti,ov7251", 0 }, + { }, +}; static struct i2c_driver ov7251_i2c_driver = { .driver = { - .of_match_table = ov7251_of_match, - .name = "ov7251", + .name = OV7251_NAME, + .pm = &ov7251_pm_ops, + .of_match_table = of_match_ptr(ov7251_of_match), }, - .probe_new = ov7251_probe, - .remove = ov7251_remove, + .probe = &ov7251_probe, + .remove = &ov7251_remove, + .id_table = ov7251_match_id, }; -module_i2c_driver(ov7251_i2c_driver); +static int __init sensor_mod_init(void) +{ + return i2c_add_driver(&ov7251_i2c_driver); +} -MODULE_DESCRIPTION("Omnivision OV7251 Camera Driver"); -MODULE_AUTHOR("Todor Tomov "); +static void __exit sensor_mod_exit(void) +{ + i2c_del_driver(&ov7251_i2c_driver); +} + +device_initcall_sync(sensor_mod_init); +module_exit(sensor_mod_exit); + +MODULE_DESCRIPTION("OmniVision ov7251 sensor driver"); MODULE_LICENSE("GPL v2");