From 6aef0738cff72229b71fa2e3b4c5359729888f7f Mon Sep 17 00:00:00 2001 From: shengfei Xu Date: Wed, 26 May 2021 17:20:09 +0800 Subject: [PATCH] regulator: fan53555: fix regulator resume error if the default voltage and the regulator on/off in suspend can't be changed in runtime, the fan53555 not need the resume function. fix regulator resume error as follows log: [ 12.726012] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.726041] PM: Device regulator.1 failed to resume: error -1 [ 12.726623] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.726641] PM: Device regulator.2 failed to resume: error -1 [ 12.727216] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.727246] PM: Device regulator.3 failed to resume: error -1 [ 12.727826] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.727855] PM: Device regulator.4 failed to resume: error -1 [ 12.728437] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.728467] PM: Device regulator.5 failed to resume: error -1 [ 12.729045] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.729074] PM: Device regulator.6 failed to resume: error -1 [ 12.729653] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.729683] PM: Device regulator.7 failed to resume: error -1 [ 12.730195] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.730222] PM: Device regulator.8 failed to resume: error -1 [ 12.730783] dpm_run_callback(): regulator_resume+0x0/0x68 returns -1 [ 12.730812] PM: Device regulator.9 failed to resume: error -1 Fixes: af1b6e88fa5f ("regulator: fan53555: add fan53555 resume") Change-Id: Iab3ef39e6bc218eab12430d43299f8e85d6e465e Signed-off-by: shengfei Xu --- drivers/regulator/fan53555.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 1c52203578eb..192c2edceb93 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -204,6 +204,9 @@ static int fan53555_resume(struct regulator_dev *rdev) { int ret; + if (!rdev->constraints->state_mem.changeable) + return 0; + ret = fan53555_set_suspend_enable(rdev); if (ret) return ret;