From 6d03ca09dd973c38e6184f507da9d4fc5add5dd7 Mon Sep 17 00:00:00 2001 From: Liang He Date: Sat, 2 Jul 2022 09:44:49 +0800 Subject: [PATCH] UPSTREAM: of: device: Fix missing of_node_put() in of_dma_set_restricted_buffer We should use of_node_put() for the reference 'node' returned by of_parse_phandle() which will increase the refcount. Bug: 254441685 Fixes: fec9b625095f ("of: Add plumbing for restricted DMA pool") Co-authored-by: Miaoqian Lin Signed-off-by: Liang He Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20220702014449.263772-1-windhl@126.com (cherry picked from commit d17e37c41b7ed38459957a5d2968ba61516fd5c2) Signed-off-by: Lee Jones Change-Id: Ib56e5a7b71e8785b5d8e7947cdbee7be501cfd21 --- drivers/of/device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/of/device.c b/drivers/of/device.c index 7a662cd62abf..a4ed61f868f4 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -102,8 +102,11 @@ of_dma_set_restricted_buffer(struct device *dev, struct device_node *np) * restricted-dma-pool region is allowed. */ if (of_device_is_compatible(node, "restricted-dma-pool") && - of_device_is_available(node)) + of_device_is_available(node)) { + of_node_put(node); break; + } + of_node_put(node); } /*