From 6d7e14aaab3039a852f4d102a774eed39d5061e8 Mon Sep 17 00:00:00 2001 From: William Wu Date: Mon, 6 Jun 2022 15:11:04 +0800 Subject: [PATCH] phy: rockchip: inno-usb3: Fix missing error code in rockchip_u3phy_probe() The error code is missing in this code scenario, add the error code 'PTR_ERR(provider)' to the return value ret. Eliminate the follow smatch warning: drivers/phy/rockchip/phy-rockchip-inno-usb3.c:937 rockchip_u3phy_probe() warn: missing error code 'ret' Signed-off-by: William Wu Change-Id: If534350cdae1ee09b210c0d475aa2b8673dc7c64 --- drivers/phy/rockchip/phy-rockchip-inno-usb3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb3.c b/drivers/phy/rockchip/phy-rockchip-inno-usb3.c index dec985df1722..9d9a5fd444bf 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb3.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb3.c @@ -933,8 +933,10 @@ static int rockchip_u3phy_probe(struct platform_device *pdev) } provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); - if (IS_ERR_OR_NULL(provider)) + if (IS_ERR(provider)) { + ret = PTR_ERR(provider); goto put_child; + } rockchip_u3phy_rest_deassert(u3phy, U3PHY_MAC_RST); rockchip_u3phy_clk_disable(u3phy);