diff --git a/include/linux/sock_diag.h b/include/linux/sock_diag.h index 110978dc9af1..7c07754d711b 100644 --- a/include/linux/sock_diag.h +++ b/include/linux/sock_diag.h @@ -23,13 +23,8 @@ struct sock_diag_handler { int sock_diag_register(const struct sock_diag_handler *h); void sock_diag_unregister(const struct sock_diag_handler *h); -struct sock_diag_inet_compat { - struct module *owner; - int (*fn)(struct sk_buff *skb, struct nlmsghdr *nlh); -}; - -void sock_diag_register_inet_compat(const struct sock_diag_inet_compat *ptr); -void sock_diag_unregister_inet_compat(const struct sock_diag_inet_compat *ptr); +void sock_diag_register_inet_compat(int (*fn)(struct sk_buff *skb, struct nlmsghdr *nlh)); +void sock_diag_unregister_inet_compat(int (*fn)(struct sk_buff *skb, struct nlmsghdr *nlh)); u64 __sock_gen_cookie(struct sock *sk); diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c index d36beb9a9a92..73b2e36032b3 100644 --- a/net/core/sock_diag.c +++ b/net/core/sock_diag.c @@ -17,9 +17,8 @@ #include static const struct sock_diag_handler __rcu *sock_diag_handlers[AF_MAX]; - -static struct sock_diag_inet_compat __rcu *inet_rcv_compat; - +static int (*inet_rcv_compat)(struct sk_buff *skb, struct nlmsghdr *nlh); +static DEFINE_MUTEX(sock_diag_table_mutex); static struct workqueue_struct *broadcast_wq; DEFINE_COOKIE(sock_cookie); @@ -182,20 +181,19 @@ void sock_diag_broadcast_destroy(struct sock *sk) queue_work(broadcast_wq, &bsk->work); } -void sock_diag_register_inet_compat(const struct sock_diag_inet_compat *ptr) +void sock_diag_register_inet_compat(int (*fn)(struct sk_buff *skb, struct nlmsghdr *nlh)) { - xchg((__force const struct sock_diag_inet_compat **)&inet_rcv_compat, - ptr); + mutex_lock(&sock_diag_table_mutex); + inet_rcv_compat = fn; + mutex_unlock(&sock_diag_table_mutex); } EXPORT_SYMBOL_GPL(sock_diag_register_inet_compat); -void sock_diag_unregister_inet_compat(const struct sock_diag_inet_compat *ptr) +void sock_diag_unregister_inet_compat(int (*fn)(struct sk_buff *skb, struct nlmsghdr *nlh)) { - const struct sock_diag_inet_compat *old; - - old = xchg((__force const struct sock_diag_inet_compat **)&inet_rcv_compat, - NULL); - WARN_ON_ONCE(old != ptr); + mutex_lock(&sock_diag_table_mutex); + inet_rcv_compat = NULL; + mutex_unlock(&sock_diag_table_mutex); } EXPORT_SYMBOL_GPL(sock_diag_unregister_inet_compat); @@ -258,27 +256,20 @@ static int __sock_diag_cmd(struct sk_buff *skb, struct nlmsghdr *nlh) static int sock_diag_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, struct netlink_ext_ack *extack) { - const struct sock_diag_inet_compat *ptr; int ret; switch (nlh->nlmsg_type) { case TCPDIAG_GETSOCK: case DCCPDIAG_GETSOCK: - - if (!rcu_access_pointer(inet_rcv_compat)) + if (inet_rcv_compat == NULL) sock_load_diag_module(AF_INET, 0); - rcu_read_lock(); - ptr = rcu_dereference(inet_rcv_compat); - if (ptr && !try_module_get(ptr->owner)) - ptr = NULL; - rcu_read_unlock(); - - ret = -EOPNOTSUPP; - if (ptr) { - ret = ptr->fn(skb, nlh); - module_put(ptr->owner); - } + mutex_lock(&sock_diag_table_mutex); + if (inet_rcv_compat != NULL) + ret = inet_rcv_compat(skb, nlh); + else + ret = -EOPNOTSUPP; + mutex_unlock(&sock_diag_table_mutex); return ret; case SOCK_DIAG_BY_FAMILY: diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 2bd5d0ed7a6f..a3d0e18885f5 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c @@ -1445,11 +1445,6 @@ void inet_diag_unregister(const struct inet_diag_handler *h) } EXPORT_SYMBOL_GPL(inet_diag_unregister); -static const struct sock_diag_inet_compat inet_diag_compat = { - .owner = THIS_MODULE, - .fn = inet_diag_rcv_msg_compat, -}; - static int __init inet_diag_init(void) { const int inet_diag_table_size = (IPPROTO_MAX * @@ -1468,7 +1463,7 @@ static int __init inet_diag_init(void) if (err) goto out_free_inet; - sock_diag_register_inet_compat(&inet_diag_compat); + sock_diag_register_inet_compat(inet_diag_rcv_msg_compat); out: return err; @@ -1483,7 +1478,7 @@ static void __exit inet_diag_exit(void) { sock_diag_unregister(&inet6_diag_handler); sock_diag_unregister(&inet_diag_handler); - sock_diag_unregister_inet_compat(&inet_diag_compat); + sock_diag_unregister_inet_compat(inet_diag_rcv_msg_compat); kfree(inet_diag_table); }