mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-05 10:31:46 +09:00
mtd: rawnand: fix double free in atmel_pmecc_create_user()
commit d8e4771f99c0400a1873235704b28bb803c83d17 upstream.
The "user" pointer was converted from being allocated with kzalloc() to
being allocated by devm_kzalloc(). Calling kfree(user) will lead to a
double free.
Fixes: 6d734f1bfc33 ("mtd: rawnand: atmel: Fix possible memory leak")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
fdba6d5e45
commit
6ea15205d7
@@ -380,10 +380,8 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
|
|||||||
user->delta = user->dmu + req->ecc.strength + 1;
|
user->delta = user->dmu + req->ecc.strength + 1;
|
||||||
|
|
||||||
gf_tables = atmel_pmecc_get_gf_tables(req);
|
gf_tables = atmel_pmecc_get_gf_tables(req);
|
||||||
if (IS_ERR(gf_tables)) {
|
if (IS_ERR(gf_tables))
|
||||||
kfree(user);
|
|
||||||
return ERR_CAST(gf_tables);
|
return ERR_CAST(gf_tables);
|
||||||
}
|
|
||||||
|
|
||||||
user->gf_tables = gf_tables;
|
user->gf_tables = gf_tables;
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user