shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-10 04:48:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

staging: rtl8723bs: rtl8723b_hal_init.c: fix build warnings about unused variables

Browse Source 
0-day keeps spitting out annoying messages:

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3895:18: warning: variable 'ra_info2' set but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3895:8: warning: variable 'ra_info1' set but not used [-Wunused-but-set-variable]

Oddly, it's not catching all of the "set but not used" variables in this
switch statement.  Fix it up just removing the storage of the values
read.  Leave the read from the hardware as odds are it is required in
order to keep it working properly as I do not have the hardware to test
with.

I bet the whole case can be removed, but that will have to wait until
later...

Link: https://lore.kernel.org/r/20210520064144.1953251-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2021-05-20 08:41:44 +02:00
parent d23dc8cd13
commit 7ca8d993d0
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
View File

@@ -3892,22 +3892,19 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
{
u8 mac_id = *(u8 *)pval;
u32 cmd;
u32 ra_info1, ra_info2;
u32 rate_mask1, rate_mask2;
cmd = 0x40000100 | mac_id;
rtw_write32(padapter, REG_HMEBOX_DBG_2_8723B, cmd);
msleep(10);
ra_info1 = rtw_read32(padapter, 0x2F0);
rtw_read32(padapter, 0x2F0); // info 1
cmd = 0x40000400 | mac_id;
rtw_write32(padapter, REG_HMEBOX_DBG_2_8723B, cmd);
msleep(10);
ra_info1 = rtw_read32(padapter, 0x2F0);
ra_info2 = rtw_read32(padapter, 0x2F4);
rate_mask1 = rtw_read32(padapter, 0x2F8);
rate_mask2 = rtw_read32(padapter, 0x2FC);
rtw_read32(padapter, 0x2F0); // info 1
rtw_read32(padapter, 0x2F4); // info 2
rtw_read32(padapter, 0x2F8); // rate mask 1
rtw_read32(padapter, 0x2FC); // rate mask 2
}
break;