From 85d757f6491a33de5984621f4cb28492ec6c36bd Mon Sep 17 00:00:00 2001 From: Tao Huang Date: Mon, 28 Jun 2021 10:32:47 +0800 Subject: [PATCH] regulator: xz3216: Fix gcc this statement may fall through warning drivers/regulator/xz3216.c: In function 'xz3216_dcdc_set_suspend_mode': drivers/regulator/xz3216.c:112:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/regulator/xz3216.c:115:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/regulator/xz3216.c:165:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/regulator/xz3216.c:168:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Tao Huang Change-Id: I4709021a667a5def61361f27a1675099bcb7b45f --- drivers/regulator/xz3216.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/xz3216.c b/drivers/regulator/xz3216.c index 3bcaf898c768..54182559b161 100644 --- a/drivers/regulator/xz3216.c +++ b/drivers/regulator/xz3216.c @@ -109,11 +109,11 @@ static int xz3216_dcdc_set_mode(struct regulator_dev *dev, unsigned int mode) switch (mode) { case REGULATOR_MODE_FAST: - regmap_update_bits(xz3216->regmap, xz3216->vol_reg, - VSEL_MODE, VSEL_MODE); + return regmap_update_bits(xz3216->regmap, xz3216->vol_reg, + VSEL_MODE, VSEL_MODE); case REGULATOR_MODE_NORMAL: - regmap_update_bits(xz3216->regmap, xz3216->vol_reg, - VSEL_MODE, 0); + return regmap_update_bits(xz3216->regmap, xz3216->vol_reg, + VSEL_MODE, 0); default: DBG("error:dcdc_xz3216 only auto and pwm mode\n"); return -EINVAL; @@ -162,11 +162,11 @@ static int xz3216_dcdc_set_suspend_mode(struct regulator_dev *dev, switch (mode) { case REGULATOR_MODE_FAST: - regmap_update_bits(xz3216->regmap, xz3216->vol_reg, - VSEL_MODE, VSEL_MODE); + return regmap_update_bits(xz3216->regmap, xz3216->vol_reg, + VSEL_MODE, VSEL_MODE); case REGULATOR_MODE_NORMAL: - regmap_update_bits(xz3216->regmap, xz3216->vol_reg, - VSEL_MODE, 0); + return regmap_update_bits(xz3216->regmap, xz3216->vol_reg, + VSEL_MODE, 0); default: DBG_ERR("error:dcdc_xz3216 only auto and pwm mode\n"); return -EINVAL;