shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

usb: typec: ucsi: Fix connector check on init

Browse Source 
commit ce4c8d21054ae9396cd759fe6e8157b525616dc4 upstream.

Fix issues when initially checking for a connector change:
- Use the correct connector number not the entire CCI.
- Call ->read under the PPM lock.
- Remove a bogus READ_ONCE.

Fixes: 808a8b9e0b87 ("usb: typec: ucsi: Check for notifications after init")
Cc: stable@kernel.org
Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240401210515.1902048-1-lk@c--e.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian A. Ehrhardt
2024-04-01 23:05:15 +02:00
committed by Greg Kroah-Hartman
parent 91a7af8cb3
commit 85e6aa4f6e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/typec/ucsi/ucsi.c
View File

@@ -1302,11 +1302,13 @@ static int ucsi_init(struct ucsi *ucsi)
ucsi->connector = connector; ucsi->connector = connector;
ucsi->ntfy = ntfy; ucsi->ntfy = ntfy;
mutex_lock(&ucsi->ppm_lock);
ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci)); ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci));
mutex_unlock(&ucsi->ppm_lock);
if (ret) if (ret)
return ret; return ret;
if (UCSI_CCI_CONNECTOR(READ_ONCE(cci))) if (UCSI_CCI_CONNECTOR(cci))
ucsi_connector_change(ucsi, cci); ucsi_connector_change(ucsi, UCSI_CCI_CONNECTOR(cci));
return 0; return 0;