From 89527bc74515e1779f7e95cfea3e3bf1f449eae0 Mon Sep 17 00:00:00 2001 From: Chaoyi Chen Date: Fri, 16 May 2025 15:28:13 +0800 Subject: [PATCH] drm/rockchip: vop: Do not commit writeback when all win disabled Change-Id: Iaa96aebaf2d6f225ebd3a35648b219510d38f648 Signed-off-by: Chaoyi Chen --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 58c24ca09751..60bb12a15a55 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1859,6 +1859,11 @@ static void vop_wb_commit(struct drm_crtc *crtc) fb->pitches[0], &wb_state->yrgb_addr); drm_writeback_queue_job(wb_conn, conn_state); + if (!vop->enabled_win_mask) { + drm_warn(vop->drm_dev, "Writeback can not work when all plane are disabled!"); + drm_writeback_signal_completion(&vop->wb.conn, 0); + return; + } fifo_throd = fb->pitches[0] >> 4; if (fifo_throd > vop->data->wb->fifo_depth)