From 8bda65645de5dcdc49a2d54ff2918b594c070aeb Mon Sep 17 00:00:00 2001 From: Jianqun Xu Date: Wed, 5 Jan 2022 14:41:45 +0800 Subject: [PATCH] dma-buf: dma-buf-cache: fix error condition for cache fail Fixes: 43d1db61b020 ("dma-buf: dma-buf-cache: fix error case for attach / detach") Signed-off-by: Jianqun Xu Change-Id: Idc5a052bb3c2ee1c3ae45dbeac8d57178595a22f --- drivers/dma-buf/dma-buf-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-buf-cache.c b/drivers/dma-buf/dma-buf-cache.c index f5b75752f22e..7bfa6a5e5fc4 100644 --- a/drivers/dma-buf/dma-buf-cache.c +++ b/drivers/dma-buf/dma-buf-cache.c @@ -119,7 +119,7 @@ struct dma_buf_attachment *dma_buf_cache_attach(struct dma_buf *dmabuf, /* Cache attachment */ attach = dma_buf_attach(dmabuf, dev); - if (!IS_ERR_OR_NULL(attach)) { + if (IS_ERR_OR_NULL(attach)) { kfree(cache); return attach; }